From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [patch 6/8] pull RT tasks Date: Fri, 19 Oct 2007 21:24:53 +0200 Message-ID: <1192821893.9471.17.camel@lappy> References: <20071019184254.456160632@goodmis.org> <20071019184336.983272715@goodmis.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: LKML , RT , Linus Torvalds , Andrew Morton , Ingo Molnar , Thomas Gleixner , Gregory Haskins To: Steven Rostedt Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:48790 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758798AbXJSTZ6 (ORCPT ); Fri, 19 Oct 2007 15:25:58 -0400 In-Reply-To: <20071019184336.983272715@goodmis.org> Sender: linux-rt-users-owner@vger.kernel.org List-Id: linux-rt-users.vger.kernel.org On Fri, 2007-10-19 at 14:43 -0400, Steven Rostedt wrote: > plain text document attachment (rt-balance-pull-tasks.patch) > +static int pull_rt_task(struct rq *this_rq) > +{ > + struct task_struct *next; > + struct task_struct *p; > + struct rq *src_rq; > + int this_cpu = this_rq->cpu; > + int cpu; > + int ret = 0; > + > + assert_spin_locked(&this_rq->lock); > + > + if (likely(!atomic_read(&rt_overload))) > + return 0; This seems to be the only usage of rt_overload. I'm not sure its worth keeping it around for this. > + next = pick_next_task_rt(this_rq); > + > + for_each_cpu_mask(cpu, rto_cpumask) { > + if (this_cpu == cpu) > + continue; ... > + } > + > + return ret; > +}