Re: [PATCH] powerpc: mpic: minor optimization of ipi handler

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, jgarzik@pobox.com
Subject: Re: [PATCH] powerpc: mpic: minor optimization of ipi handler
Date: Sat, 20 Oct 2007 09:17:39 +1000	[thread overview]
Message-ID: <1192835859.17235.12.camel@pasglop> (raw)
In-Reply-To: <20071019185110.GA11911@lixom.net>

On Fri, 2007-10-19 at 13:51 -0500, Olof Johansson wrote:
> Jeff Garzik pointed out that we don't actually have to lookup the mpic
> instance since it's passed in as the interrupt handler data for IPIs.

Note that's typically one of the annoying case where we use "irq"
for a good reasons, getting the way of Jeff attempt at removing
this argument.

I suppose a working approach would be to have 4 mpic IPI handlers...

Ben. 

> Signed-off-by: Olof Johansson <olof@lixom.net>
> 
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index e479388..6bf56f4 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -612,11 +612,10 @@ static inline void mpic_eoi(struct mpic *mpic)
>  }
>  
>  #ifdef CONFIG_SMP
> -static irqreturn_t mpic_ipi_action(int irq, void *dev_id)
> +static irqreturn_t mpic_ipi_action(int irq, void *data)
>  {
> -	struct mpic *mpic;
> +	struct mpic *mpic = data;
>  
> -	mpic = mpic_find(irq, NULL);
>  	smp_message_recv(mpic_irq_to_hw(irq) - mpic->ipi_vecs[0]);
>  
>  	return IRQ_HANDLED;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev