All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
	nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [NFS] [GIT] NFS client fixes for 2.6.23++
Date: Sat, 20 Oct 2007 13:22:37 -0400	[thread overview]
Message-ID: <1192900957.7440.10.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0710191929340.3794@woody.linux-foundation.org>


On Fri, 2007-10-19 at 19:32 -0700, Linus Torvalds wrote:
> 
> On Fri, 19 Oct 2007, Erez Zadok wrote:
> > 
> > Trond, with Linus's latest tree, you need to #include <linux/sched.h> in
> > fs/nfs/unlink.c, else I get:
> > 
> >   CC [M]  fs/nfs/unlink.o
> > fs/nfs/unlink.c: In function 'nfs_dec_sillycount':
> > fs/nfs/unlink.c:67: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
> ...
> 
> Hmm? Which architecture?
> 
> That said, I do think that there is a distinct lack of proper includes in 
> that file. It seems to depend on getting much of the includes indirectly 
> from <linux/nfs_fs.h> and friends. And with different architectures having 
> different header files..
> 
> 		Linus

This ought to fix it.
----------------------------------------------------
From: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Sat, 20 Oct 2007 13:21:04 -0400
NFS: Fix the include files needed by fs/nfs/unlink.c

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---

 fs/nfs/unlink.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c
index 6ecd46c..057e6ce 100644
--- a/fs/nfs/unlink.c
+++ b/fs/nfs/unlink.c
@@ -5,9 +5,14 @@
  *
  */
 
+#include <asm/atomic.h>
+#include <linux/dcache.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <linux/dcache.h>
+#include <linux/sched.h>
+#include <linux/spinlock.h>
+#include <linux/wait.h>
+#include <linux/sunrpc/auth.h>
 #include <linux/sunrpc/sched.h>
 #include <linux/sunrpc/clnt.h>
 #include <linux/nfs_fs.h>

      parent reply	other threads:[~2007-10-20 17:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 21:23 [GIT] NFS client fixes for 2.6.23++ Trond Myklebust
2007-10-20  1:41 ` Olof Johansson
2007-10-20  1:41   ` Olof Johansson
2007-10-20 17:24   ` Trond Myklebust
2007-10-20 17:24     ` [NFS] " Trond Myklebust
2007-10-20  2:19 ` Erez Zadok
2007-10-20  2:19   ` Erez Zadok
2007-10-20  2:32   ` Linus Torvalds
2007-10-20  2:32     ` Linus Torvalds
2007-10-20  2:44     ` Erez Zadok
2007-10-20  2:44       ` Erez Zadok
2007-10-20  2:57       ` Linus Torvalds
2007-10-20  2:57         ` Linus Torvalds
2007-10-20  4:02         ` Erez Zadok
2007-10-20  4:02           ` Erez Zadok
2007-10-20 17:22     ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192900957.7440.10.camel@heimdal.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=ezk@cs.sunysb.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfs@lists.sourceforge.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.