All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: "Denis V. Lunev" <den@sw.ru>
Cc: netdev@vger.kernel.org, "Denis V. Lunev" <den@openvz.org>,
	"David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: Regression in current git - Network Manager fails (bisected)
Date: Mon, 22 Oct 2007 11:57:25 -0400	[thread overview]
Message-ID: <1193068645.30205.22.camel@localhost.localdomain> (raw)
In-Reply-To: <471C6BEC.4010604@sw.ru>

On Mon, 2007-10-22 at 13:22 +0400, Denis V. Lunev wrote:
> We have spent some time with the problem with Alexey and there are no 
> guesses for now.
> 
> Is it possible to name exact version of Network Manager and all 
> libraries related + provide us an output of strace with full buffers 
> send/received from netlink. Something like
>      strace -v -x -s 32768 <nm>

NM uses netlink in two places; libnl (from Thomas Graf) and some custom
code for listening for interface up/down events and wireless events.

It looks like that code comes from libnl's lib/handlers.c where it
thinks the received message is invalid.

I'm pretty sure the code that checks carrier status of the device isn't
libnl code; so maybe the error message (which should get fixed of
course) isn't in the same path as the link detection.

The link detection comes from src/nm-netlink-monitor.c, so maybe we
should look at debugging there.

Dan

> Regards,
> 	Den
> 
> Joseph Fannin wrote:
> > Network Manager (the freedesktop.org one) fails to work with Linus's
> > current git on a couple of different boxes I have here.  All the boxes
> > have different NIC types, with different drivers.
> > 
> > I've bisected it down to cd40b7d3983c708aabe3d3008ec64ffce56d33b0 ,
> > "[NET]: make netlink user -> kernel interface synchronious".  I've
> > double checked this by testing the kernel as of the immediately
> > previous commit; Network Manager works with that one, as it did on all
> > my machines in 2.6.23-mm1.
> > 
> > The netlink change seems to confuse N-M, and it somehow decides that
> > there's no link beat, so doesn't try to bring up the interface.  If I
> > run "ifconfig eth0 up", N-M will decide there's a carrier after all
> > and takes over.  Ethtool detects the link state correctly even with
> > the interface down.
> > 
> > If I down the interface again with ifconfig, N-M brings it right back
> > up without a problem, but if I kill N-M, it'll down the interface
> > before it exits, and fail in the same way as before when restarted.
> > 
> > N-M also emits this error:
> > 
> > "-- Error: Invalid message: type=DONE length=20 flags=<MULTI> sequence-nr=1193012574 pid=1185943630"
> > 
> > ...which it doesn't do on kernels where it works normally.
> > strace'ing NetworkManager shows that it prints that message just after
> > talking over a netlink socket.
> > 
> > Networking otherwise works fine here with the latest git and N-M, if I
> > use the ifconfig "trick" to get the link up.
> > 
> > --
> > Joseph Fannin
> > jfannin@gmail.com
> > 
> > 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2007-10-22 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22  0:58 Regression in current git - Network Manager fails (bisected) Joseph Fannin
2007-10-22  9:22 ` Denis V. Lunev
2007-10-22 15:57   ` Dan Williams [this message]
2007-10-23 12:11     ` Thomas Graf
2007-10-23 13:09       ` Denis V. Lunev
2007-10-23 13:38         ` Thomas Graf
2007-10-23 14:10           ` Dan Williams
2007-10-25  9:06             ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193068645.30205.22.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=davem@davemloft.net \
    --cc=den@openvz.org \
    --cc=den@sw.ru \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.