From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
kvm-ppc-devel
<kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [kvm-ppc-devel] [PATCH 1/2] [v1] consolidate i386 & x86-64 user dir make rules
Date: Tue, 23 Oct 2007 10:24:01 -0500 [thread overview]
Message-ID: <1193153041.22407.11.camel@basalt> (raw)
In-Reply-To: <1193152877.22407.8.camel@basalt>
On Tue, 2007-10-23 at 10:21 -0500, Hollis Blanchard wrote:
>
> > -CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g -fomit-frame-pointer \
> > - -Wall
> > +CFLAGS += $(autodepend-flags) -g -fomit-frame-pointer -Wall
> > CFLAGS += $(call cc-option, -fno-stack-protector, "")
> > CFLAGS += $(call cc-option, -fno-stack-protector-all, "")
>
> You seem to be adding "-I $(KERNELDIR)/include" twice: once here, and
> once in each config-*.mak file.
My bad; I read the diff backwards. :)
Are you sure about that move though? Why doesn't every arch need that -I
switch?
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-23 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 5:57 [PATCH 1/2] [v1] consolidate i386 & x86-64 user dir make rules Jerone Young
2007-10-23 15:21 ` [kvm-ppc-devel] " Hollis Blanchard
2007-10-23 15:24 ` Hollis Blanchard [this message]
2007-10-23 15:35 ` Jerone Young
2007-10-23 15:45 ` Jerone Young
2007-10-23 15:52 ` Hollis Blanchard
2007-10-23 16:06 ` Jerone Young
2007-10-23 18:10 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193153041.22407.11.camel@basalt \
--to=hollisb-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.