From: "Huang, Ying" <ying.huang@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Andi Kleen <ak@suse.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Chandramouli Narayanan <mouli@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support
Date: Fri, 26 Oct 2007 09:03:11 +0800 [thread overview]
Message-ID: <1193360591.23935.212.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <alpine.LFD.0.9999.0710251800250.3186@localhost.localdomain>
On Thu, 2007-10-25 at 18:09 +0200, Thomas Gleixner wrote:
> > EFI runtime
> > services initialization are implemented in efi.c. Some x86_64
> > specifics are worth noting here. On x86_64, parameters passed to UEFI
> > firmware services need to follow the UEFI calling convention. For this
> > purpose, a set of functions named lin2win<x> (<x> is the number of
> > parameters) are implemented. EFI function calls are wrapped before
> > calling the firmware service.
>
> Why needs this to be called lin2win? We do not call Windows, we call
> EFI services, so please use a naming convention which is related to
> the functionality of the code.
>
> > + *
> > + * Function calling ABI conversion from SYSV to Windows for x86_64
>
> Again, these are wrappers to access EFI and not Windows.
EFI uses the Windows x86_64 calling convention. The lin2win may be a
more general naming convention that can be used for some other code (the
NDISwrapper?) in the future. Do you agree?
Best Regards,
Huang Ying
next prev parent reply other threads:[~2007-10-26 1:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 6:57 [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support Huang, Ying
2007-10-25 16:09 ` Thomas Gleixner
2007-10-25 16:28 ` H. Peter Anvin
2007-10-25 16:55 ` Eric W. Biederman
2007-10-25 16:56 ` Arjan van de Ven
2007-10-25 17:05 ` H. Peter Anvin
2007-10-25 17:39 ` Eric W. Biederman
2007-10-25 17:51 ` H. Peter Anvin
2007-10-25 18:04 ` Eric W. Biederman
2007-10-25 20:36 ` H. Peter Anvin
2007-10-25 22:20 ` Eric W. Biederman
2007-10-25 22:29 ` H. Peter Anvin
2007-10-26 2:31 ` Huang, Ying
2007-10-26 2:14 ` Huang, Ying
2007-10-25 17:06 ` Eric W. Biederman
2007-10-26 1:28 ` Huang, Ying
2007-10-25 17:06 ` Andi Kleen
2007-10-25 17:08 ` H. Peter Anvin
2007-10-25 17:30 ` Eric W. Biederman
2007-10-26 2:12 ` Huang, Ying
2007-10-26 1:03 ` Huang, Ying [this message]
2007-10-26 8:48 ` Thomas Gleixner
2007-10-26 9:30 ` Huang, Ying
2007-10-26 10:20 ` Thomas Gleixner
2007-10-26 11:37 ` Andi Kleen
2007-10-26 11:31 ` Alan Cox
2007-10-26 17:00 ` H. Peter Anvin
2007-10-29 1:05 ` Huang, Ying
2007-10-26 3:36 ` Huang, Ying
2007-10-26 4:11 ` H. Peter Anvin
2007-10-25 17:01 ` Eric W. Biederman
2007-10-26 1:17 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193360591.23935.212.camel@caritas-dev.intel.com \
--to=ying.huang@intel.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mouli@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.