Re: iwl3945 lists supported rates backwards

[Pavel Roskin <proski@gnu.org>]

On Mon, 2007-10-29 at 15:12 +0100, Johannes Berg wrote:
> > With disable_hw_scan=1, probe requests have the same problem as the
> > association requests, namely they don't have CCK rates in the supported
> > rates:
> 
> This is because mac80211 uses the order in which the rates are
> registered, and with iwlwifi that is "OFDM, CCK". See
> iwl_init_hw_rates() and iwl_init_geos().

Yes, it's working now!  Thank you!  That's the patch I actually applied:

--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -5414,10 +5414,10 @@ static int iwl_init_geos(struct iwl_priv *priv)
 	 * is supported by a mode -- and the first match is taken
 	 */
 
-	if (modes[G].num_channels)
-		ieee80211_register_hwmode(priv->hw, &modes[G]);
 	if (modes[B].num_channels)
 		ieee80211_register_hwmode(priv->hw, &modes[B]);
+	if (modes[G].num_channels)
+		ieee80211_register_hwmode(priv->hw, &modes[G]);
 	if (modes[A].num_channels)
 		ieee80211_register_hwmode(priv->hw, &modes[A]);
 

Should I submit it formally?

-- 
Regards,
Pavel Roskin