All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Clemens Ladisch" <cladisch@fastmail.net>
To: "Timofei V. Bondarenko" <tim@ipi.ac.ru>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] cmipci at 96kHz
Date: Tue, 30 Oct 2007 09:44:12 +0100	[thread overview]
Message-ID: <1193733852.1219.1218549445@webmail.messagingengine.com> (raw)
In-Reply-To: <4725F492.9020304@ipi.ac.ru>

Timofei V. Bondarenko wrote:
> This patch adds support for 88.2k, 96k, and 128k samplerates
> on cmi8738-55 chip.
> Analog playback works fine on all channels.
> Analog capture works well too, though the extra samples seems 
> interpolated by hardware.
> spdif playback and capture works fine.

> +		freq_ext = CM_CH0_SRATE_88K | CM_CH0_SRATE_96K;

I'd guess there should be a new symbol CM_CH0_SRATE_128K.

> +		case 88200:
> +			freq = 44100;
> +		case 96000:
> +			freq = 48000;
> +		case 128000:
> +			freq = 32000; /* not matter, 

Wouldn't it be simpler to divide freq by two in all three cases?


Regards,
Clemens

  reply	other threads:[~2007-10-30  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 14:56 [PATCH] cmipci at 96kHz Timofei V. Bondarenko
2007-10-30  8:44 ` Clemens Ladisch [this message]
2007-10-30 14:22   ` Timofei V. Bondarenko
2007-10-31  8:25     ` Takashi Iwai
2007-10-31 16:25       ` Timofei V. Bondarenko
2007-10-31 14:24         ` Takashi Iwai
2007-10-31 16:44           ` Timofei V. Bondarenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193733852.1219.1218549445@webmail.messagingengine.com \
    --to=cladisch@fastmail.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=tim@ipi.ac.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.