From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: jdike@addtoit.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: per-bdi-throttling: synchronous writepage doesn't work correctly
Date: Thu, 01 Nov 2007 18:39:30 +0100 [thread overview]
Message-ID: <1193938770.27652.328.camel@twins> (raw)
In-Reply-To: <E1Indqb-00049a-00@dorka.pomaz.szeredi.hu>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Thu, 2007-11-01 at 18:28 +0100, Miklos Szeredi wrote:
> > The page not having PG_writeback set on return is a hint, but not fool
> > proof, it could be the device is just blazing fast.
>
> Hmm, does it actually has to be foolproof though? What will happen if
> bdi_writeout_inc() is called twice for the page? The device will get
> twice the number of pages it deserves? That's not all that bad,
> especially since that is a really really fast device.
Basically, yes.
But then again, that would require auditing all ->writepage() callsites.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-11-01 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 16:49 per-bdi-throttling: synchronous writepage doesn't work correctly Miklos Szeredi
2007-11-01 16:49 ` Miklos Szeredi
2007-11-01 16:51 ` Peter Zijlstra
2007-11-01 17:00 ` Miklos Szeredi
2007-11-01 17:00 ` Miklos Szeredi
2007-11-01 17:09 ` Peter Zijlstra
2007-11-01 17:16 ` Peter Zijlstra
2007-11-01 17:16 ` Peter Zijlstra
2007-11-01 18:35 ` Peter Zijlstra
2007-11-01 18:35 ` Peter Zijlstra
2007-11-01 19:19 ` Miklos Szeredi
2007-11-01 19:19 ` Miklos Szeredi
2007-11-01 19:55 ` Peter Zijlstra
2007-11-01 19:55 ` Peter Zijlstra
2007-11-01 17:28 ` Miklos Szeredi
2007-11-01 17:28 ` Miklos Szeredi
2007-11-01 17:39 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193938770.27652.328.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.