From: Rumen Bogdanovski <rumen@voicecho.com>
To: LVS Development mailing list <lvs-devel@linuxvirtualserver.org>
Cc: Julian Anastasov <ja@ssi.bg>,
Wensong Zhang <wensong@linux-vs.org>,
netdev@vger.kernel.org, Graeme Fowler <graeme@graemef.net>,
Joseph Mack NA3T <jmack@wm7d.net>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [lvs-devel] [patch 2/2] ipvs: Syncrhonise Closing of Connections
Date: Fri, 02 Nov 2007 11:47:20 +0200 [thread overview]
Message-ID: <1193996840.5339.5.camel@lappy> (raw)
In-Reply-To: <20071102005348.GA20398@verge.net.au>
I should have been very tired to miss this one when I looked at the
patch...
I looked again in the version I have tested. For some
reason/net/ipv4/ipvs/ip_vs_sync.c is not patched at all, this is what I
have missed.
Rumen
On Fri, 2007-11-02 at 09:53 +0900, Simon Horman wrote:
> On Fri, Nov 02, 2007 at 01:36:07AM +0200, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Thu, 1 Nov 2007, Simon Horman wrote:
> >
> > > --- net-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:17:55.000000000 +0900
> > > +++ net-2.6/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:20:30.000000000 +0900
> > > @@ -332,7 +332,7 @@ static void ip_vs_process_message(const
> > > s->daddr, s->dport,
> > > flags, dest);
> > > if (dest)
> >
> > Is that correct? Sorry, I was flooded with different versions
> > of this patch and I'm not sure if it is the final one.
> >
> > > - atomic_dec(&dest->refcnt);
> > > + ip_vs_dest_get(dest);
> > > if (!cp) {
> > > IP_VS_ERR("ip_vs_conn_new failed\n");
> > > return;
>
> The ip_vs_dest_get() call shouldn't be there.
> I'll double check the rest of the patch.
>
prev parent reply other threads:[~2007-11-02 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 9:28 [patch 0/2] ipvs: avoid overcommit on the standby, take II Simon Horman
2007-11-01 9:28 ` [patch 1/2] ipvs: Bind connections on stanby if the destination exists Simon Horman
2007-11-01 9:28 ` [patch 2/2] ipvs: Syncrhonise Closing of Connections Simon Horman
2007-11-01 23:36 ` Julian Anastasov
2007-11-02 0:53 ` Simon Horman
2007-11-02 9:47 ` Rumen Bogdanovski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193996840.5339.5.camel@lappy \
--to=rumen@voicecho.com \
--cc=davem@davemloft.net \
--cc=graeme@graemef.net \
--cc=ja@ssi.bg \
--cc=jmack@wm7d.net \
--cc=lvs-devel@linuxvirtualserver.org \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.