From: Alex Williamson <alex.williamson@hp.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [PATCH] Move dmi_scan_machine() call ealier
Date: Wed, 07 Nov 2007 16:40:29 +0000 [thread overview]
Message-ID: <1194453629.6463.27.camel@lappy> (raw)
In-Reply-To: <1194370267.31834.176.camel@bling>
On Wed, 2007-11-07 at 08:30 -0800, Luck, Tony wrote:
> > Thanks for the review Simon. Is the patch below more like what
> > you're thinking? I agree that check_bugs doesn't initial seem like the
> > most appropriate place to setup DMI, but think about what DMI is
> > typically used for in the kernel.
>
> Then re-name check_bugs() to something more suited to the things that
> it is now doing. [I think that was what Simon was hinting at].
Re-naming check_bugs() becomes a cross architecture endeavor. Since
x86 calls dmi_scan_machine() in setup_arch(), this would only be for
ia64. Perhaps the right answer is to make dmi_scan_machine() callable
from setup_arch() on ia64, but that requires an safer early ioremap, and
I'm still not sure what that should look like. Thanks,
Alex
--
Alex Williamson HP Open Source & Linux Org.
next prev parent reply other threads:[~2007-11-07 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 17:31 [PATCH] Move dmi_scan_machine() call ealier Alex Williamson
2007-11-07 7:15 ` Simon Horman
2007-11-07 15:14 ` Alex Williamson
2007-11-07 16:30 ` Luck, Tony
2007-11-07 16:40 ` Alex Williamson [this message]
2007-11-08 1:59 ` Simon Horman
2007-11-08 2:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194453629.6463.27.camel@lappy \
--to=alex.williamson@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.