Re: [PATCH] US-122L Driver, v0

["Clemens Ladisch" <cladisch@fastmail.net>]

Karsten Wiese wrote:
> attached patches implement a simple driver for the tascam us-122l.

>  	QUIRK_AUDIO_EDIROL_UA700_UA25,
>  	QUIRK_AUDIO_EDIROL_UA1000,
>  	QUIRK_AUDIO_EDIROL_UA101,
> -
> +	QUIRK_MIDI_US122L,
>  	QUIRK_TYPE_COUNT
>  };
 
Why not put it together with the other QUIRK_MIDI_ symbols?

>  		break;
> +	case QUIRK_MIDI_US122L:
> +		umidi->usb_protocol_ops = &snd_usbmidi_122l_ops;
>  	case QUIRK_MIDI_FIXED_ENDPOINT:
>  		memcpy(&endpoints[0], quirk->data,
>  		       sizeof(struct snd_usb_midi_endpoint_info));

Aaargh!  If you really want to do it this way, at least add a
"/* fall through */" so that it's obvious that this is not a mistake.


Regards,
Clemens