All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6] ibm_newemac: Add ET1011c PHY support
Date: Thu, 08 Nov 2007 19:42:24 +1100	[thread overview]
Message-ID: <1194511344.6561.0.camel@pasglop> (raw)
In-Reply-To: <200711080941.46894.sr@denx.de>


> > +static struct mii_phy_def et1011c_phy_def = {
> > +        .phy_id         = 0x0282f000,
> > +        .phy_id_mask    = 0x0fffff00,
> > +        .name           = "ET1011C Gigabit Ethernet",
> > +        .ops            = &et1011c_phy_ops
> > +};
> > +
> > +
> > +
> > +
> > +
> 
> Nitpicking: Too many empty lines for my taste.

Agreed, I though I had removed them, looks like I didn't. Will fix that
before submitting.

Thanks,
Ben.

  reply	other threads:[~2007-11-08  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08  8:06 [PATCH 0/6] ibm_newemac: Pending patches for review Benjamin Herrenschmidt
2007-11-08  8:06 ` [PATCH 1/6] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support Benjamin Herrenschmidt
2007-11-08  8:06 ` [PATCH 2/6] ibm_newemac: Add ET1011c " Benjamin Herrenschmidt
2007-11-08  8:41   ` Stefan Roese
2007-11-08  8:42     ` Benjamin Herrenschmidt [this message]
2007-11-08 12:08       ` Josh Boyer
2007-11-08 20:55         ` Benjamin Herrenschmidt
2007-11-09  5:44           ` Stefan Roese
2007-11-08  8:06 ` [PATCH 3/6] ibm_newemac: Fix ZMII refcounting bug Benjamin Herrenschmidt
2007-11-08  8:43   ` Stefan Roese
2007-11-08  8:06 ` [PATCH 4/6] ibm_newemac: Workaround reset timeout when no link Benjamin Herrenschmidt
2007-11-08  8:44   ` Stefan Roese
2007-11-08  8:07 ` [PATCH 5/6] ibm_newemac: Cleanup/Fix RGMII MDIO support detection Benjamin Herrenschmidt
2007-11-08  9:24   ` Stefan Roese
2007-11-08  8:07 ` [PATCH 6/6] ibm_newemac: Cleanup/fix support for STACR register variants Benjamin Herrenschmidt
2007-11-08  9:38   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194511344.6561.0.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.