From: Alex Williamson <alex.williamson@hp.com>
To: Keir Fraser <keir@xensource.com>, John Levon <john.levon@sun.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [Xen-staging] [xen-unstable] xend: Allow for non-existent xen-python-path binary.
Date: Thu, 08 Nov 2007 09:17:31 -0700 [thread overview]
Message-ID: <1194538651.31834.269.camel@bling> (raw)
In-Reply-To: <200711081534.lA8FYN7l005628@latara.uk.xensource.com>
On Thu, 2007-11-08 at 15:34 +0000, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser <keir@xensource.com>
> # Date 1194535934 0
> # Node ID 0ebac857649591de0e1b57605b054552afb03297
> # Parent c0bdfda5183d5e9dca5c9bc7a68a6cf40e3f6c58
> xend: Allow for non-existent xen-python-path binary.
> On Solaris, xen-python-path is unnecessary.
This completely breaks xend for me:
# xend start
Traceback (most recent call last):
File "/usr/sbin/xend", line 36, in ?
xpp = os.path.join(os.path.dirname(sys.argv[0], 'xen-python-path'))
TypeError: dirname() takes exactly 1 argument (2 given)
Alex
> ---
> tools/misc/xend | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff -r c0bdfda5183d -r 0ebac8576495 tools/misc/xend
> --- a/tools/misc/xend Thu Nov 08 14:50:01 2007 +0000
> +++ b/tools/misc/xend Thu Nov 08 15:32:14 2007 +0000
> @@ -33,13 +33,14 @@ import time
> import time
> import commands
>
> -result = commands.getstatusoutput(os.path.join(os.path.dirname(sys.argv[0]),
> - 'xen-python-path'))
> -if result[0] != 0:
> - print >>sys.stderr, result[1]
> - sys.exit(1)
> +xpp = os.path.join(os.path.dirname(sys.argv[0], 'xen-python-path'))
> +if os.path.exists(xpp):
> + result = commands.getstatusoutput(xpp)
> + if result[0] != 0:
> + print >>sys.stderr, result[1]
> + sys.exit(1)
>
> -sys.path.append(result[1])
> + sys.path.append(result[1])
>
> from xen.xend.server import SrvDaemon
>
>
> _______________________________________________
> Xen-staging mailing list
> Xen-staging@lists.xensource.com
> http://lists.xensource.com/xen-staging
>
--
Alex Williamson HP Open Source & Linux Org.
next parent reply other threads:[~2007-11-08 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200711081534.lA8FYN7l005628@latara.uk.xensource.com>
2007-11-08 16:17 ` Alex Williamson [this message]
2007-11-08 16:19 ` Re: [Xen-staging] [xen-unstable] xend: Allow for non-existent xen-python-path binary Keir Fraser
2007-11-08 16:25 ` Alex Williamson
2007-11-08 16:37 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194538651.31834.269.camel@bling \
--to=alex.williamson@hp.com \
--cc=john.levon@sun.com \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.