From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: PowerPC dev list <Linuxppc-dev@ozlabs.org>
Subject: Re: pcspkr device, pnpPNP,100
Date: Mon, 12 Nov 2007 11:09:51 +1100 [thread overview]
Message-ID: <1194826191.18185.6.camel@pasglop> (raw)
In-Reply-To: <9e4733910711111607i35294d3ja43e1c616a3427bd@mail.gmail.com>
On Sun, 2007-11-11 at 19:07 -0500, Jon Smirl wrote:
>
> This code should be in a device driver so that it can be selected with
> Kconfig. Can we #ifdef it now as a hint? I could make it a device
> driver but I don't have any hardware to test it on.
>
> I'm trying to get the mpc5200 kernel to build with platform bus turned
> off (only of_platform bus). I'm almost there, just a couple more odd
> places to patch up.
Just don't do platform ifdef's, ever.
What you can do however is Kconfig options that get selected by
platforms that need a given service, and then use that as an ifdef for
that service.
A bit like how we select what interrupt controller drivers to built-in
for example.
Ben.
next prev parent reply other threads:[~2007-11-12 0:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 23:35 pcspkr device, pnpPNP,100 Jon Smirl
2007-11-12 0:03 ` Benjamin Herrenschmidt
2007-11-12 0:07 ` Jon Smirl
2007-11-12 0:09 ` Benjamin Herrenschmidt [this message]
2007-11-12 0:18 ` Jon Smirl
2007-11-12 1:07 ` Benjamin Herrenschmidt
2007-11-12 10:48 ` Geert Uytterhoeven
2007-11-12 13:51 ` Jon Smirl
2007-11-12 13:57 ` Geert Uytterhoeven
2007-11-12 14:50 ` Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194826191.18185.6.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.