From: Peter Zijlstra <peterz@infradead.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: axboe@kernel.dk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] Include header required for INT_MAX
Date: Mon, 12 Nov 2007 11:21:10 +0100 [thread overview]
Message-ID: <1194862870.7179.13.camel@twins> (raw)
In-Reply-To: <Pine.LNX.4.64.0711112349580.15517@fbirervta.pbzchgretzou.qr>
On Sun, 2007-11-11 at 23:52 +0100, Jan Engelhardt wrote:
> >> Nack, we shoiuld never include userspace headers in kernel headers,
> >> an even more never add !__KERNEL__ ifdefs. Just make sure your
> >> programs include limit.h before including linux/cdrom.h.
> >
> >I think header files should be complete, and should not use undefined
> >macros, picking up every random definition that may be in effect when
> >the header is included, don't you agree?
>
> No, because I be damn sure that some developers try compiling programs
> in non-linux environments (cygwin, solaris, andyourpersonaldistro, you
> name it) which do not have to adhere to <limits.h>. It might use
> <cosmiclimits.h> instead, or whatever.
> Hence, such extra includes are a nogo.
Surely ISO-C99 has something to say on this subject?
next prev parent reply other threads:[~2007-11-12 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 22:52 [PATCH] Include header required for INT_MAX Jan Engelhardt
2007-11-12 10:21 ` Peter Zijlstra [this message]
2007-11-12 10:46 ` Andreas Schwab
2007-11-12 10:51 ` Robert P. J. Day
2007-11-12 12:06 ` Andreas Schwab
2007-11-12 12:57 ` Vegard Nossum
2007-11-12 13:37 ` Jan Engelhardt
2007-11-12 20:50 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2007-11-10 14:55 Thomas Koeller
2007-11-10 15:56 ` Christoph Hellwig
2007-11-11 0:52 ` Thomas Koeller
2007-11-10 16:48 ` Alexander E. Patrakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194862870.7179.13.camel@twins \
--to=peterz@infradead.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.