Re: [PATCH 4/4] o80211s: (zd1211rw-mac80211) support for mesh interface

[Luis Carlos Cobo <luisca@cozybit.com>]

On Sat, 2007-11-10 at 11:18 +0100, Johannes Berg wrote:
> > +		{ CR_CAM_MODE,			MODE_AP_WDS},
> 
> Shouldn't that depend on the interface type? I.e. set it for WDS/MESH
> but clear it for station so that the station won't ack WDS frames? OTOH,
> it may just as well ack WDS frames for itself...

Yes, it doesn't look like it does any harm.

> 
> > +			zd_mac_config_beacon(hw, conf->beacon);
> > +			kfree_skb(conf->beacon);
> > +			zd_set_beacon_interval(&mac->chip, BCN_MODE_IBSS | 100);
> 
> Does that mean you're hardcoding the beacon interval here while before
> you confused me how we should handle that setting in userspace? :)

I am not sure what are you referring to... anyway, by now I think it's
fine to hard code the beacon interval, but in mac80211 instead of the
driver adding a beacon_int field to ieee80211_if_conf.

-- 
Luis Carlos Cobo Rus       GnuPG ID: 44019B60
cozybit Inc.