From: Dan Williams <dcbw@redhat.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH]iwlwifi not correctly dealing with hotunplug
Date: Tue, 13 Nov 2007 10:37:03 -0500 [thread overview]
Message-ID: <1194968223.2955.33.camel@localhost.localdomain> (raw)
In-Reply-To: <200711131249.25320.oliver@neukum.org>
On Tue, 2007-11-13 at 12:49 +0100, Oliver Neukum wrote:
> It makes no sense to enable interrupts if a device has been unplugged.
> In addition if in doubt IRQ_HANDLED should be returned.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Might want to forward to linux-wireless@ ? And maybe cc the ipw2100@
sourceforge upstream lists too.
Dan
> Regards
> Oliver
>
> ----
>
> --- linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c.alt 2007-11-13 12:23:07.000000000 +0100
> +++ linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c 2007-11-13 12:26:00.000000000 +0100
> @@ -4850,7 +4850,7 @@ static irqreturn_t iwl_isr(int irq, void
> if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
> /* Hardware disappeared */
> IWL_WARNING("HARDWARE GONE?? INTA == 0x%080x\n", inta);
> - goto none;
> + goto unplugged;
> }
>
> IWL_DEBUG_ISR("ISR inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
> @@ -4858,6 +4858,7 @@ static irqreturn_t iwl_isr(int irq, void
>
> /* iwl_irq_tasklet() will service interrupts and re-enable them */
> tasklet_schedule(&priv->irq_tasklet);
> +unplugged:
> spin_unlock(&priv->lock);
>
> return IRQ_HANDLED;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-11-13 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 11:49 [PATCH]iwlwifi not correctly dealing with hotunplug Oliver Neukum
2007-11-13 15:37 ` Dan Williams [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-13 18:26 Oliver Neukum
2007-11-13 18:26 ` Oliver Neukum
2007-11-14 1:30 ` Zhu Yi
2007-11-14 1:30 ` Zhu Yi
2007-11-14 5:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194968223.2955.33.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.