From: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: kvm-ppc-devel
<kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [Disscussion] Moving x86 code out of kvm.h
Date: Thu, 15 Nov 2007 02:24:15 -0600 [thread overview]
Message-ID: <1195115055.21627.17.camel@thinkpad> (raw)
This is a continuation of a conversation I have been having with Izik
Eidus on IRC today.
I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h
would then include kvm.h and would be included by files like svm.c
instead of kvm.h.
Izik pointed out a big issue with this approach and that is it breaks
compatibility with older userspace. We believe that everyone still cares
that older userspace should be able to compile against a newer kvm
kernels. Is this true or should we just dump it?
Assuming this is true, we have come up with an interesting solution to
the problem.
- creation of new header name "portablekvm.h" (please give a better name
if you know one). This would be the new place for common code that would
normally be kvm.h.
- still create header "kvm-x86.h" for x86 code and would include this
new "portablekvm.h" header.
- keep compatibility with older userspace by taking header "kvm.h" and
jsut have it include kvm-x86.h & portablekvm.h and have no other code
(unless it's for compatibility).
What does everyone thing about this ?
Also a side discussion is should we really start thinking about having a
userspace header and stop userspace apps from including kernel headers.
This does lead to a problem where if the kernel header is updated the
userspace header must also be updated (but maybe it's time to bite the
bullet)?
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next reply other threads:[~2007-11-15 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 8:24 Jerone Young [this message]
2007-11-15 8:34 ` [Disscussion] Moving x86 code out of kvm.h Avi Kivity
[not found] ` <473C0494.2080404-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-15 8:30 ` Izik Eidus
[not found] ` <1195115455.3165.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-11-15 8:42 ` Avi Kivity
2007-11-15 16:44 ` Jerone Young
2007-11-15 10:30 ` Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A042D-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-15 10:52 ` Avi Kivity
[not found] ` <473C2509.5030308-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-15 14:02 ` Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A044F-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-15 14:21 ` Avi Kivity
[not found] ` <473C55CE.9010000-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-15 14:30 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195115055.21627.17.camel@thinkpad \
--to=jyoung5-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.