All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kiel <alexanderkiel@gmx.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] PWMconfig problem with Asus P5B Deluxe / Winbond
Date: Sun, 18 Nov 2007 17:10:24 +0000	[thread overview]
Message-ID: <1195405824.6437.35.camel@alex> (raw)
In-Reply-To: <4dfa50520711142226r2e6d1c3fy229e05d4ca43d032@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2737 bytes --]

Hi Jean,

> May I ask what shell (and version) you're using? Both sequences above
> return 255 here.

bash -version says:

GNU bash, version 3.2.25(1)-release (i486-pc-linux-gnu)
Copyright (C) 2005 Free Software Foundation, Inc.

I have a fresh and totaly normal installed Ubuntu 7.10 32-bit without
any modifications. My user account and its homedir is also new. The bad
is that this is likely the most used distributation is the next year.

> It would take a broken shell to do what you describe, if that's
> possible at all. The following command should answer your question:
> 
> echo 0 > /sys/class/hwmon/hwmon0/device/pwm1_enable ; echo 255 > /tmp/pwm1 ; cat /tmp/pwm1
> 
> Here, it prints the expected error message, then 255.

--------------------------------------------------------------------------
root@alex:~# echo 0 > /sys/class/hwmon/hwmon0/device/pwm1_enable ; echo
255 > /tmp/pwm1 ; cat /tmp/pwm1
bash: echo: write error: Invalid argument
0
255
root@alex:~# cat /tmp/pwm1
0
255
--------------------------------------------------------------------------

As you can see it prints the error message, the 0 and the 255. And you
can see both go into /temp/pwm1.

--------------------------------------------------------------------------
root@alex:~# echo 0 > /sys/class/hwmon/hwmon0/device/pwm1_enable
2>/dev/null ; echo 255 > /tmp/pwm1 ; cat /tmp/pwm1
0
255
--------------------------------------------------------------------------

Here the error goes to /dev/null.

--------------------------------------------------------------------------
root@alex:~# echo 0 > /sys/class/hwmon/hwmon0/device/pwm1_enable
>/dev/null 2>/dev/null ; echo 255 > /tmp/pwm1 ; cat /tmp/pwm1
255
--------------------------------------------------------------------------

And so the 0.

> I meant that the patch is functionally incorrect, not that I was not
> able to apply it (although it is, indeed, technically incorrect, for
> it's reverted and not in unified format.)

Ok. Excuse me. This was a simple diff between the two files. I have no
experiences in creating a real patch.

> An additional > /dev/null can certainly hurt, as it overwrites the
> previous > $ENABLE, meaning that you do NOT write the value to the
> sysfs file at all. It doesn't make a difference for you because writing
> 0 to pwm1_enable doesn't actually work with the w83627ehf driver, but
> your change breaks drivers for which it works.

Ok. Thats a good point. I thought that it redirects the hanging zero
to /dev/null. But I see echo 0 is the command and > $ENABLE is the
regirection of the stdout. But why does pwm1_enable not consume the 0
and throws the error afterwards?

Regards
Alex

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-11-18 17:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15  6:26 [lm-sensors] PWMconfig problem with Asus P5B Deluxe / Winbond David Hubbard
2007-11-15 11:08 ` Alexander Kiel
2007-11-15 19:41 ` David Hubbard
2007-11-15 23:15 ` Alexander Kiel
2007-11-16  0:24 ` David Hubbard
2007-11-16  0:41 ` Alexander Kiel
2007-11-16  0:59 ` David Hubbard
2007-11-18 15:14 ` Jean Delvare
2007-11-18 15:57 ` Alexander Kiel
2007-11-18 16:34 ` Jean Delvare
2007-11-18 17:10 ` Alexander Kiel [this message]
2007-11-18 20:09 ` Jean Delvare
2007-11-19  6:32 ` David Hubbard
2007-11-21 22:16 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1195405824.6437.35.camel@alex \
    --to=alexanderkiel@gmx.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.