All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Poorva Sonparote <psonparo@redhat.com>
Cc: mptcp@lists.linux.dev, matthieu.baerts@tessares.net
Subject: Re: [PATCH mptcp-next v4 0/2] Splitting commits for IP_TOS support in setsockopt()
Date: Wed, 27 Oct 2021 17:50:22 -0700 (PDT)	[thread overview]
Message-ID: <119548f6-ee97-48c3-ccf9-3ce623371c58@linux.intel.com> (raw)
In-Reply-To: <cover.1635367735.git.psonparo@redhat.com>

On Wed, 27 Oct 2021, Poorva Sonparote wrote:

> - patch 1/2 Add Support for IP_TOS for MPTCP setsockopt()
> - patch 2/2 Exposing  __ip_sock_set_tos() in ip.h
>
> Poorva Sonparote (2):
>  Exposing __ip_sock_set_tos() in ip.h
>  Support for IP_TOS for MPTCP setsockopt()
>
> include/net/ip.h       |  1 +
> net/ipv4/ip_sockglue.c |  2 +-
> net/mptcp/sockopt.c    | 40 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 42 insertions(+), 1 deletion(-)
>
> -- 
> 2.18.2

Hi Poorva -

Thanks! Looks like this is ready for the export branch:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>


It's not necessary to use getsockopt to implement a test for this, you 
could also use 'ss --tos' to see the tos value on the mptcp socket and the 
subflows. Would be good to have a selftest for this before upstreaming.


--
Mat Martineau
Intel

  parent reply	other threads:[~2021-10-28  0:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 21:05 [PATCH mptcp-next v4 0/2] Splitting commits for IP_TOS support in setsockopt() Poorva Sonparote
2021-10-27 21:05 ` [PATCH mptcp-next v4 1/2] Exposing __ip_sock_set_tos() in ip.h Poorva Sonparote
2021-10-27 21:05 ` [PATCH mptcp-next v4 2/2] Support for IP_TOS for MPTCP setsockopt() Poorva Sonparote
2021-10-28  0:50 ` Mat Martineau [this message]
2021-10-28 10:12   ` [PATCH mptcp-next v4 0/2] Splitting commits for IP_TOS support in setsockopt() Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=119548f6-ee97-48c3-ccf9-3ce623371c58@linux.intel.com \
    --to=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    --cc=psonparo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.