All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Alistair John Strachan <alistair@devzero.co.uk>
Cc: linux-kernel@vger.kernel.org, Ali Akcaagac <aliakc@web.de>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Jamie Lenehan <lenehan@twibble.org>,
	Oliver Neukum <oliver@neukum.name>,
	dc395x@twibble.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 44/59] drivers/scsi: Add missing "space"
Date: Tue, 20 Nov 2007 07:17:34 -0800	[thread overview]
Message-ID: <1195571854.4675.131.camel@localhost> (raw)
In-Reply-To: <200711201039.45321.alistair@devzero.co.uk>

On Tue, 2007-11-20 at 10:39 +0000, Alistair John Strachan wrote:
> On Tuesday 20 November 2007 01:53:31 Joe Perches wrote:
> > diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c
> > index 9e64b21..99403a6 100644
> > --- a/drivers/scsi/NCR_D700.c
> > +++ b/drivers/scsi/NCR_D700.c
> > @@ -182,7 +182,7 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int
> > siop, int irq,
> >
> >  	hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
> >  	if (!hostdata) {
> > -		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host"
> > +		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host "
> >  		       "data, detatching\n", siop);
> >  		return -ENOMEM;
> >  	}
> 
> If you're going to sneak in unrelated spelling/grammar changes, you might as 
> well do it unilaterally.

 drivers/scsi/NCR_D700.c    |    4 ++--
 drivers/scsi/aic7xxx_old.c |    2 +-
 drivers/scsi/dc395x.c      |    2 +-
 drivers/scsi/hosts.c       |    2 +-
 drivers/scsi/iscsi_tcp.c   |    6 +++---
 drivers/scsi/scsi_proc.c   |    2 +-
 drivers/scsi/scsi_scan.c   |    2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c
index 9e64b21..36281c5 100644
--- a/drivers/scsi/NCR_D700.c
+++ b/drivers/scsi/NCR_D700.c
@@ -182,8 +182,8 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int siop, int irq,
 
 	hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
 	if (!hostdata) {
-		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host"
-		       "data, detatching\n", siop);
+		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host "
+		       "data, detaching\n", siop);
 		return -ENOMEM;
 	}
 
diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c
index 8f8db5f..c79a452 100644
--- a/drivers/scsi/aic7xxx_old.c
+++ b/drivers/scsi/aic7xxx_old.c
@@ -3716,7 +3716,7 @@ aic7xxx_pci_intr(struct aic7xxx_host *p)
   pci_read_config_byte(p->pdev, PCI_STATUS + 1, &status1);
 
   if ( (status1 & DPE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) )
-    printk(WARN_LEAD "Data Parity Error during PCI address or PCI write"
+    printk(WARN_LEAD "Data Parity Error during PCI address or PCI write "
       "phase.\n", p->host_no, -1, -1, -1);
   if ( (status1 & SSE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) )
     printk(WARN_LEAD "Signal System Error Detected\n", p->host_no,
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index a9def6e..f98747c 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -1520,7 +1520,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb,
 	}
 #endif
 	if (acb->active_dcb) {
-		dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a"
+		dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a "
 			"command while another command (pid#%li) is active.",
 			srb->cmd->serial_number,
 			acb->active_dcb->active_srb ?
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 24271a8..b53f681 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -141,7 +141,7 @@ int scsi_host_set_state(struct Scsi_Host *shost, enum scsi_host_state state)
  illegal:
 	SCSI_LOG_ERROR_RECOVERY(1,
 				shost_printk(KERN_ERR, shost,
-					     "Illegal host state transition"
+					     "Invalid host state transition "
 					     "%s->%s\n",
 					     scsi_host_state_name(oldstate),
 					     scsi_host_state_name(state)));
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 4bcf916..2e0d9a1 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -389,7 +389,7 @@ iscsi_r2t_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
 	}
 
 	if (r2t->data_length > session->max_burst)
-		debug_scsi("invalid R2T with data len %u and max burst %u."
+		debug_scsi("invalid R2T with data len %u and max burst %u. "
 			   "Attempting to execute request.\n",
 			    r2t->data_length, session->max_burst);
 
@@ -900,13 +900,13 @@ more:
 
 		memcpy(&recv_digest, conn->data, sizeof(uint32_t));
 		if (recv_digest != tcp_conn->in.datadgst) {
-			debug_tcp("iscsi_tcp: data digest error!"
+			debug_tcp("iscsi_tcp: data digest error! "
 				  "0x%x != 0x%x\n", recv_digest,
 				  tcp_conn->in.datadgst);
 			iscsi_conn_failure(conn, ISCSI_ERR_DATA_DGST);
 			return 0;
 		} else {
-			debug_tcp("iscsi_tcp: data digest match!"
+			debug_tcp("iscsi_tcp: data digest match! "
 				  "0x%x == 0x%x\n", recv_digest,
 				  tcp_conn->in.datadgst);
 			tcp_conn->in_progress = IN_PROGRESS_WAIT_HEADER;
diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c
index bb6f051..781dc85 100644
--- a/drivers/scsi/scsi_proc.c
+++ b/drivers/scsi/scsi_proc.c
@@ -123,7 +123,7 @@ void scsi_proc_host_add(struct Scsi_Host *shost)
 	p = create_proc_read_entry(name, S_IFREG | S_IRUGO | S_IWUSR,
 			sht->proc_dir, proc_scsi_read, shost);
 	if (!p) {
-		printk(KERN_ERR "%s: Failed to register host %d in"
+		printk(KERN_ERR "%s: Failed to register host %d in "
 		       "%s\n", __FUNCTION__, shost->host_no,
 		       sht->proc_name);
 		return;
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 40ea71c..e0a47ed 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1124,7 +1124,7 @@ static void scsi_sequential_lun_scan(struct scsi_target *starget,
 	unsigned int sparse_lun, lun, max_dev_lun;
 	struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
 
-	SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of"
+	SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of "
 				    "%s\n", starget->dev.bus_id));
 
 	max_dev_lun = min(max_scsi_luns, shost->max_lun);



  reply	other threads:[~2007-11-20 15:17 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-20  1:47 [PATCH 01/59] arch/ia64: Add missing "space" Joe Perches
2007-11-20  1:47 ` [PATCH 00/59] trivial - Add missing "space" in multiline quoted strings Joe Perches
2007-11-20  1:47 ` [PATCH 01/59] arch/ia64: Add missing "space" Joe Perches
2007-11-20  1:47 ` [PATCH 02/59] arch/mips: " Joe Perches
2007-11-20  1:47   ` Joe Perches
2007-11-21 22:34   ` Ralf Baechle
2007-11-20  1:47 ` [PATCH 03/59] arch/powerpc: " Joe Perches
2007-11-20  1:47   ` Joe Perches
2007-11-20  1:47     ` Joe Perches
2007-11-20  1:47 ` [PATCH 04/59] arch/ppc: " Joe Perches
2007-11-20  1:47   ` Joe Perches
2007-11-20  1:47     ` Joe Perches
2007-11-20  1:47 ` [PATCH 05/59] arch/s390: " Joe Perches
2007-11-20  1:47   ` Joe Perches
2007-11-20  1:47     ` [PATCH 06/59] arch/sparc: " Joe Perches
2007-11-20  1:47       ` Joe Perches
2007-11-20  1:47         ` [PATCH 07/59] arch/sparc64: " Joe Perches
2007-11-20  1:47           ` Joe Perches
2007-11-20  7:43             ` David Miller
2007-11-20  7:43               ` David Miller
2007-11-20  7:45         ` [PATCH 06/59] arch/sparc: " David Miller
2007-11-20  7:45           ` David Miller
2007-11-20  7:48           ` Joe Perches
2007-11-20  7:48             ` Joe Perches
2007-11-20  8:05             ` David Miller
2007-11-20  8:05               ` David Miller
2007-11-20  8:27   ` [PATCH 05/59] arch/s390: " Heiko Carstens
2007-11-20  1:48 ` [uml-devel] [PATCH 08/59] arch/um: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48     ` Joe Perches
2007-11-20 17:05   ` [uml-devel] " Jeff Dike
2007-11-20 17:05     ` Jeff Dike
2007-11-20  1:48 ` [PATCH 09/59] arch/x86: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48     ` Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  2:05   ` Dave Jones
2007-11-20  2:05     ` Dave Jones
2007-11-20  1:48 ` [PATCH 10/59] drivers/acpi: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  2:53     ` Len Brown
2007-11-20  1:48 ` [PATCH 11/59] drivers/block: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 12/59] drivers/cdrom: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 13/59] drivers/char: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 14/59] drivers/cpufreq: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48     ` [lm-sensors] [PATCH 15/59] drivers/hwmon: " Joe Perches
2007-11-20  1:48       ` Joe Perches
2007-11-21 18:37         ` [lm-sensors] " Jean Delvare
2007-11-21 18:37           ` Jean Delvare
2007-12-06 13:21       ` Mark M. Hoffman
2007-12-06 13:21         ` Mark M. Hoffman
2007-11-20  2:06   ` [PATCH 14/59] drivers/cpufreq: " Dave Jones
2007-11-20  2:06     ` Dave Jones
2007-11-20  1:48 ` [PATCH 16/59] drivers/i2c: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20 19:51     ` Jean Delvare
2007-11-20  1:48 ` [PATCH 17/59] drivers/ide: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-22 21:23     ` Bartlomiej Zolnierkiewicz
2007-11-20  1:48 ` [PATCH 18/59] drivers/ieee1394: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-22 19:23     ` Stefan Richter
2007-11-20  1:48 ` [PATCH 19/59] drivers/infiniband: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20 21:14     ` Roland Dreier
2007-11-20  1:48 ` [PATCH 20/59] drivers/input: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 21/59] drivers/isdn: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 22/59] drivers/macintosh: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 23/59] drivers/media/dvb: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 24/59] drivers/media/radio: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 25/59] drivers/media/video: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  2:24   ` [v4l-dvb-maintainer] " Brandon Philips
2007-11-20  4:08     ` Joe Perches
2007-11-20 12:06       ` Mauro Carvalho Chehab
2007-11-20  1:48 ` [PATCH 26/59] drivers/message: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 27/59] drivers/misc: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 29/59] drivers/net/chelsio: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-24  1:57     ` Jeff Garzik
2007-11-24  1:57       ` Jeff Garzik
2007-11-20  1:48 ` [PATCH 30/59] drivers/net/cxgb3: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 31/59] drivers/net/ixgb: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-26 23:16     ` Kok, Auke
2007-11-26 23:16       ` Kok, Auke
2007-11-20  1:48 ` [PATCH 32/59] drivers/net/netxen: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 33/59] drivers/net/sk98lin: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 34/59] drivers/net/wan: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20 23:52     ` Krzysztof Halasa
2007-11-20  1:48 ` [PATCH 35/59] drivers/net/wireless: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48     ` Joe Perches
2007-11-20 16:41   ` Dan Williams
2007-11-20 16:41     ` Dan Williams
2007-11-20  1:48 ` [PATCH 36/59] drivers/net: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 37/59] drivers/pci: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 38/59] drivers/rtc: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 39/59] drivers/s390: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  8:52   ` Heiko Carstens
2007-11-20  1:48 ` [PATCH 40/59] drivers/scsi/aic7xxx: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 41/59] drivers/scsi/aic94xx: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 42/59] drivers/scsi/lpfc: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:48 ` [PATCH 43/59] drivers/scsi/qla4xxx: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  1:49 ` [PATCH 28/59] drivers/mtd: " Joe Perches
2007-11-20  1:48   ` Joe Perches
2007-11-20  1:49     ` Joe Perches
2007-11-20  1:53 ` [PATCH 44/59] drivers/scsi: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20 10:39     ` Alistair John Strachan
2007-11-20 15:17       ` Joe Perches [this message]
2007-11-20  1:53 ` [PATCH 45/59] drivers/serial: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  1:53 ` [PATCH 46/59] drivers/usb: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  2:19     ` David Brownell
2007-11-20  1:53 ` [PATCH 47/59] fs/ocfs2: " Joe Perches
2007-11-19 18:13   ` [Ocfs2-devel] " Mark Fasheh
2007-11-20  2:13     ` Mark Fasheh
2007-11-20  1:53   ` Joe Perches
2007-11-20  1:54     ` [Ocfs2-devel] " Joe Perches
2007-11-20  1:53 ` [PATCH 48/59] fs/proc: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  1:53 ` [PATCH 49/59] fs/ufs: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-22  4:02     ` Evgeniy Dushistov
2007-11-20  1:53 ` [PATCH 50/59] net/bridge: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:48     ` David Miller
2007-11-20  1:53 ` [PATCH 51/59] net/dccp: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:48   ` David Miller
2007-11-20  7:48     ` David Miller
2007-11-20  1:53 ` [PATCH 52/59] net/ipv4: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:48     ` David Miller
2007-11-20  6:59   ` Simon Horman
2007-11-20  1:53 ` [PATCH 53/59] net/ipv6: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:48     ` David Miller
2007-11-20  1:53 ` [PATCH 54/59] net/irda: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:49     ` David Miller
2007-11-20  1:53 ` [PATCH 55/59] net/sctp: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:49     ` David Miller
2007-11-20  1:53 ` [NFS] [PATCH 56/59] net/sunrpc: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  1:53     ` Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  7:49     ` [NFS] " David Miller
2007-11-20  7:49     ` David Miller
2007-11-20  1:53 ` [PATCH 57/59] security/selinux: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  3:10     ` James Morris
2007-11-20  1:53 ` [PATCH 58/59] sound/isa: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-26  7:25     ` Takashi Iwai
2007-11-20  1:53 ` [PATCH 59/59] sound/oss: " Joe Perches
2007-11-20  1:53   ` Joe Perches
2007-11-20  6:54 ` [PATCH 01/59] arch/ia64: " Simon Horman
2007-11-20  6:54   ` Simon Horman
2007-11-20  7:09   ` Joe Perches
2007-11-20  7:09     ` Joe Perches
2007-11-20  7:41     ` Simon Horman
2007-11-20  7:41       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1195571854.4675.131.camel@localhost \
    --to=joe@perches.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aliakc@web.de \
    --cc=alistair@devzero.co.uk \
    --cc=dc395x@twibble.org \
    --cc=lenehan@twibble.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.