From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 1/3] The sysctl shadows Date: Tue, 20 Nov 2007 09:16:49 -0800 Message-ID: <1195579009.29578.7.camel@localhost> References: <4742C73C.3010904@openvz.org> <4742C86E.6060705@openvz.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4742C86E.6060705-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Pavel Emelyanov Cc: Linux Containers , Cedric Le Goater , "Eric W. Biederman" List-Id: containers.vger.kernel.org On Tue, 2007-11-20 at 14:43 +0300, Pavel Emelyanov wrote: > > +static void ctl_free_table(struct ctl_table *t) > +{ > + struct ctl_table *tmp; > + > + for (tmp = t; tmp->ctl_name || tmp->procname; tmp++) > + if (tmp->child) > + ctl_free_table(tmp->child); > + > + kfree(t); > +} Are you worried about the recursion at all? -- Dave