Re: [PATCH] fb_ddc: Fix DDC lines quirk

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Fri, 2007-11-23 at 20:53 +0100, Jean Delvare wrote:
> On Thu, 22 Nov 2007 06:58:49 +1100, Benjamin Herrenschmidt wrote:
> > 
> > On Sun, 2007-11-18 at 14:21 +0100, Jean Delvare wrote:
> > > The code in fb_ddc_read() is said to be based on the implementation
> > > of the radeon driver:
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fc5891c8a3ba284f13994d7bc1f1bfa8283982de
> > > 
> > > However, comparing the old radeon driver code with the new fb_ddc code
> > > reveals some differences. Most notably, the I2C bus lines are held at
> > > the end of the function, while the original code was releasing them
> > > (as the comment above correctly says.)
> > 
> >  .../...
> > 
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > 
> > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> Thanks. Antonino, this patch fixes two reported regressions. Can you
> please send it to Linus before 2.6.24 is released? Thanks.

It should also be send to -stable I believe and possibly distros.

Cheers,
Ben.



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/