From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Al Niessner <Al.Niessner@jpl.nasa.gov>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Where is the interrupt going?
Date: Sat, 24 Nov 2007 08:53:53 +1100 [thread overview]
Message-ID: <1195854833.7195.24.camel@pasglop> (raw)
In-Reply-To: <1195693710.5544.240.camel@morte.jpl.nasa.gov>
On Wed, 2007-11-21 at 17:08 -0800, Al Niessner wrote:
>
> p8620 = pci_get_device (APC8620_VENDOR_ID, APC8620_DEVICE_ID, p8620);
> <... fail if p8620 is 0 ...>
> apcsi[i].ret_val = register_chrdev (MAJOR_NUM,
>
> DEVICE_NAME,
>
> &apc8620_ops);
> <... fail if ret_val < 0 ...>
> apcsi[i].board_irq = p8620->irq;
> status = request_irq (apcsi[i].board_irq,
> apc8620_handler,
> IRQF_DISABLED,
> DEVICE_NAME,
> (void*)&apcsi[i]);
First, that's obviously not the proper way to do a PCI driver but I
suppose you know that :-)
Then, make sure you call pci_enable_device() at one point, don't some
platforms perform the actual IRQ routing that late ? (And don't sample
pdev->irq before the pci_enable_device(), sample it afterward).
Cheers,
Ben.
next prev parent reply other threads:[~2007-11-23 21:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 1:08 Where is the interrupt going? Al Niessner
2007-11-22 1:56 ` Alan Cox
2007-11-22 2:14 ` Kyle McMartin
2007-11-22 2:16 ` Jesper Juhl
2007-11-22 23:56 ` niessner
2007-11-22 2:20 ` Kyle McMartin
2007-11-23 0:48 ` niessner
2007-11-23 1:25 ` Alan Cox
2007-11-23 1:58 ` Bartlomiej Zolnierkiewicz
2007-11-23 10:36 ` Alan Cox
2007-11-23 3:18 ` Marin Mitov
2007-11-23 4:31 ` niessner
2007-11-23 8:16 ` Jiri Slaby
2007-11-22 2:50 ` Arjan van de Ven
2007-11-23 21:53 ` Benjamin Herrenschmidt [this message]
2007-11-26 22:49 ` Al Niessner
[not found] <fa.KsmqgW5tYuaXUkIKwnbJk9eJIAI@ifi.uio.no>
[not found] ` <fa.JGl5fAfWYHut6bLbEcD35M84qbY@ifi.uio.no>
[not found] ` <fa.4GMGd+vtd9BoH5cWYyPKXdddZG4@ifi.uio.no>
2007-11-23 1:20 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195854833.7195.24.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Al.Niessner@jpl.nasa.gov \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.