Re: [Buildroot] [PATCH 3/3] package/sysdig: bump to 0.29.1

[Francis Laniel <flaniel@linux.microsoft.com>]

Hi.

Le jeudi 14 avril 2022, 20:05:06 BST Arnout Vandecappelle a écrit :
> On 14/04/2022 20:54, Arnout Vandecappelle wrote:
> > On 14/04/2022 19:43, Francis Laniel wrote:
> [snip]
> 
> >> +# sysdig needs falcosecurity-libs sources, so we set the souce directory
> >> here. +# It will sadly compile again falcosecurity-libs, so we also need
> >> to set again +# grpc_cpp_plugin.
> >> +SYSDIG_CONF_OPTS +=
> >> -DFALCOSECURITY_LIBS_SOURCE_DIR=$(BUILD_DIR)/falcosecurity-libs-e5c53d648
> >> f3c4694385bbe488e7d47eaa36c229a
> >> -DGRPC_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin \
> > 
> >  This is not nice (as you wrote in the cover letter). If there's really no
> > way to tell sysdig to use the libs installed in STAGING_DIR, then the
> > solution is to remove falconsecurity-libs and instead download it as part
> > of the sysdig package. There are (fortunately) not many examples of that
> > in Buildroot, but there's something a bit similar in android-tools.
> 
>   Just to be clear: the *preferred* solution is to patch
> cmake/modules/falcosecurity-libs.cmake so it supports a system-installed
> falcosecurity-libs. (And then send that patch upstream to sysdig, of
> course).

Thank for your reviews and sorry for some misake I made (I was not aware of 
make legal-info, I will take the habit to run it now).

I will try to find the best solution.
Another one I thought about was to set falcosecurity-libs as a generic-
package, so the .mk will just the source and the compilation can happen in 
sysdig.mk.
What it is your opinion about this proposal?

> 
>   Regards,
>   Arnout
> 
> > # Take this version from cmake/modules/falcosecurity-libs.cmake
> > SYSDIG_FALCOSECURITY_LIBS_VERSION =
> > e5c53d648f3c4694385bbe488e7d47eaa36c229a SYSDIG_EXTRA_DOWNLOADS = $(call
> > github,falcosecurity,libs,$(SYSDIG_FALCOSECURITY_LIBS_VERSION))/falcosecur
> > ity-libs-$(SYSDIG_FALCOSECURITY_LIBS_VERSION).tar.gz define
> > SYSDIG_EXTRACT_FALCOSECURITY_LIBS
> >         $(call suitable-extractor,$(notdir $(SYSDIG_EXTRA_DOWNLOADS))) \
> >                 $(SYSDIG_DL_DIR)/$(notdir $(SYSDIG_EXTRA_DOWNLOADS)) | \
> >                 $(TAR) -C $(@D)/falcosecurity-libs --strip-components=1 \
> >             $(TAR_OPTIONS) -
> > endef
> > SYSDIG_POST_EXTRACT_HOOKS += SYSDIG_EXTRACT_FALCOSECURITY_LIBS
> > 
> > (you'll need to adapt the above to make sure it's extracted in the right
> > place.)
> > 
> > 
> >  Since the driver etc. are then part of the sysdig package again, not as
> > much will change. Just some directory names.
> > 
> >  BTW, please also mention in the commit message that the issue with the
> > driver is fixed in recent falcosecurity/libs
> > 
> >  Regards,
> >  Arnout
> > 
> >> + -DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson
> >>     SYSDIG_MODULE_SUBDIRS = driver
> >>   SYSDIG_MODULE_MAKE_OPTS = KERNELDIR=$(LINUX_DIR)
> >>   -$(eval $(kernel-module))
> >>   $(eval $(cmake-package))




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot