From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IwdBs-0005jN-D7 for mharc-grub-devel@gnu.org; Mon, 26 Nov 2007 07:35:56 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IwdBo-0005id-W0 for grub-devel@gnu.org; Mon, 26 Nov 2007 07:35:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IwdBn-0005i7-9R for grub-devel@gnu.org; Mon, 26 Nov 2007 07:35:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IwdBn-0005i4-4h for grub-devel@gnu.org; Mon, 26 Nov 2007 07:35:51 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1IwdBm-0000mf-MD for grub-devel@gnu.org; Mon, 26 Nov 2007 07:35:50 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 26 Nov 2007 07:35:41 -0500 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 40757618FE1; Mon, 26 Nov 2007 07:35:41 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1196072924.26555.13.camel@localhost.localdomain> References: <1195873630.7449.8.camel@dv> <1196029564.26555.9.camel@localhost.localdomain> <1196072924.26555.13.camel@localhost.localdomain> Content-Type: text/plain Date: Mon, 26 Nov 2007 07:35:40 -0500 Message-Id: <1196080540.13422.7.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 (2.12.1-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Lubomir Kundrak Subject: Re: [PATCH] Fix for linker build ID in Fedora 8 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2007 12:35:53 -0000 Hello! On Mon, 2007-11-26 at 11:28 +0100, Lubomir Kundrak wrote: > > I attach the patch I use. The first hunk is basically the same as yours, > > the second one is self-explanatory. > > Actually, the first hunk should better look like this: > http://lists.gnu.org/archive/html/grub-devel/2007-11/msg00187.html The objcopy test exists to detect certain breakage in objcopy. I'm not sure that testing it in the condition that it only copies .text is sufficient to find the original problem. Surely, that will need some software archeology. The test comes from GRUB 1. Anyway, I'll rather test objcopy under conditions close to those used in the build process. And what's the build ID for? Why do we want to keep it? -- Regards, Pavel Roskin