All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattias Nissler <mattias.nissler@gmx.de>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Michael Wu <flamingice@sourmilk.net>
Subject: Re: [RFC/T][PATCH][V3] mac80211: Exponential moving average	estimate for rc80211_simple
Date: Tue, 27 Nov 2007 22:30:44 +0100	[thread overview]
Message-ID: <1196199044.8298.15.camel@localhost> (raw)
In-Reply-To: <474C32CB.9090301@lwfinger.net>


On Tue, 2007-11-27 at 09:07 -0600, Larry Finger wrote:
> Johannes Berg wrote:
> > On Mon, 2007-11-26 at 22:30 +0100, Mattias Nissler wrote:
> >> This changes rc80211_simple failed frame percentage estimation to use an
> >> exponential moving average method. Failed frames percentage is sampled over
> >> time and a smoothed average is computed. This average is examined periodically
> >> and the rate adjusted eventually.
> >>
> >> Compared to the old method this new approach is much more responsive. The old
> >> method used plain tx success/failure counters. This made rate control very
> >> unresponsive after a short time of using the interface, since old data wouldn't
> >> age properly.
> > 
> > Sounds sane and better than before. If it works we can apply this I
> > guess.
> 
> I have not done any rigorous testing of this patch; however, it has not caused any harm on my system.

Good to hear. I've tested it with rt61pci and rt73usb. I guess you
tested b43[legacy]. Any other test results, especially in low signal
quality situations would be of great help.

Mattias


  reply	other threads:[~2007-11-27 21:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 21:30 [RFC/T][PATCH][V3] mac80211: Exponential moving average estimate for rc80211_simple Mattias Nissler
2007-11-27 14:13 ` Johannes Berg
2007-11-27 15:07   ` Larry Finger
2007-11-27 21:30     ` Mattias Nissler [this message]
2007-11-27 22:01       ` Larry Finger
2007-11-27 21:29   ` Mattias Nissler
2007-11-27 15:35 ` Stefano Brivio
2007-11-27 21:38   ` Mattias Nissler
2007-11-27 23:29     ` Stefano Brivio
2007-11-28 16:34       ` Mattias Nissler
2007-11-28 17:43         ` Stefano Brivio
2007-11-29  1:59           ` Mattias Nissler
2007-11-29  4:02             ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196199044.8298.15.camel@localhost \
    --to=mattias.nissler@gmx.de \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.