From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [PATCH] sungem: fix napi regression with reset work
Date: Wed, 28 Nov 2007 10:28:44 +1100 [thread overview]
Message-ID: <1196206124.7157.60.camel@pasglop> (raw)
In-Reply-To: <1196107328.8459.8.camel@johannes.berg>
On Mon, 2007-11-26 at 21:02 +0100, Johannes Berg wrote:
> sungem's gem_reset_task() will unconditionally try to disable NAPI even
> when it's called while the interface is not operating and hence the NAPI
> struct isn't enabled. Make napi_disable() depend on gp->running.
>
> Also removes a superfluous test of gp->running in the same function.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> Not exactly sure how I got there but I did get stuck in there (sysrq-W)
> when I plugged in the network cable and booted the computer on the other
> end of it... while the interface was down. I would've thought that the
> driver wouldn't even notice the fact that I plugged in the cable while
> the interface is down, but maybe it does. Or it sets up the device
> wrongly at resume time when the interface was down at suspend.
>
> In any case, this should fix the issue.
Thanks.
Ben.
next prev parent reply other threads:[~2007-11-27 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 20:02 [PATCH] sungem: fix napi regression with reset work Johannes Berg
2007-11-27 23:28 ` Benjamin Herrenschmidt [this message]
2007-11-29 10:57 ` Herbert Xu
2007-12-03 9:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196206124.7157.60.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.