Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

[Laurent Vivier <Laurent.Vivier@bull.net>]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

Le mercredi 28 novembre 2007 à 14:24 +0000, Samuel Thibault a écrit :
> Hi,
> 
> Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit :
> > +    ret = posix_memalign((void**)&buf, 0x200, 512);
> 
> For making this more easily portable, maybe it should be a new
> qemu_memalign() function?  Also, the alignment may probably be better as
> a global macro, since the alignment requirements depend on the OS.

I think O_DIRECT is linux specific whereas posix_memalign() is part of
POSIX specification. And the memory alignement should only needed by the
implemetation of O_DIRECT on linux.

But I have nothing against to write a qemu_memalign().

Laurent
-- 
------------- Laurent.Vivier@bull.net  --------------
       "Any sufficiently advanced technology is
  indistinguishable from magic." - Arthur C. Clarke

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]