All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: olof@lixom.net, linuxppc-dev@ozlabs.org
Subject: Re: [RFC/PATCH] Add a device_initcall to machdep_calls
Date: Sat, 01 Dec 2007 09:58:06 +1100	[thread overview]
Message-ID: <1196463486.13230.116.camel@pasglop> (raw)
In-Reply-To: <20071130225043.12499.86364.stgit@trillian.secretlab.ca>


On Fri, 2007-11-30 at 15:51 -0700, Grant Likely wrote:
> 
> Add a device_initcall hook to machdep_calls so that platform code
> doesn't
> need to register device_initcalls that must first check what platform
> it is running on.
> 
> This should (slightly) speed boot time on kernels that support a lot
> of
> boards and make device_initcall hooks slightly simpler to implement
> because the platform doesn't need to be tested when called.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> 
> Please comment; I think this is a good change, but I'd like some
> feedback.

Hrm... I'm not too sure about it... 

My initial idea for dealing with that issue was more along the lines of
defining a set of

machine_xxx_initcall(mach, function)

Where xxx is (arch,core,subsys,fs,device, whatever...)

Those could, at first be implemented as a simple macro wrapper that
expands to a function that tests machine_is() and calls the function,
and later one, we can do more fancy things, such as ELF sections with
function pointers in them.

Ben.

  reply	other threads:[~2007-11-30 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 22:51 [RFC/PATCH] Add a device_initcall to machdep_calls Grant Likely
2007-11-30 22:58 ` Benjamin Herrenschmidt [this message]
2007-11-30 23:30   ` Grant Likely
2007-11-30 23:32     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196463486.13230.116.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.