From: Pascal Obry <pascal.obry@gmail.com>
To: git@vger.kernel.org
Cc: Pascal Obry <pascal@obry.net>
Subject: [PATCH] Set OLD_ICONV on Cygwin.
Date: Sat, 1 Dec 2007 10:49:22 +0100 [thread overview]
Message-ID: <1196502562-1052-1-git-send-email-pascal@obry.net> (raw)
Cygwin still has old definition for the iconv() second
parameter. This patch fixes the last warning on Cygwin.
This has been tested with Cygwin 1.5.24.
Signed-off-by: Pascal Obry <pascal@obry.net>
---
Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index e869b85..fa3398c 100644
--- a/Makefile
+++ b/Makefile
@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)
NEEDS_LIBICONV = YesPlease
NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
+ OLD_ICONV = UnfortunatelyYes
# There are conflicting reports about this.
# On some boxes NO_MMAP is needed, and not so elsewhere.
# Try commenting this out if you suspect MMAP is more efficient
--
1.5.3.6.985.g65c6a4
next reply other threads:[~2007-12-01 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-01 9:49 Pascal Obry [this message]
2007-12-03 18:49 ` [PATCH] Set OLD_ICONV on Cygwin Pascal Obry
2007-12-04 9:32 ` Andreas Ericsson
-- strict thread matches above, loose matches on Subject: below --
2007-12-04 13:39 Pascal Obry
2007-12-04 13:43 ` Andreas Ericsson
2007-12-04 17:54 ` Junio C Hamano
2007-12-04 21:59 ` Junio C Hamano
2007-12-04 22:12 ` Pascal Obry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196502562-1052-1-git-send-email-pascal@obry.net \
--to=pascal.obry@gmail.com \
--cc=git@vger.kernel.org \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.