Re: [Xen-staging] [xen-unstable] xsm: Consolidate xsm processing within domain control hypercall.

[Alex Williamson <alex.williamson@hp.com>]

  Does this work right across a PV domain save/restore on x86?  On ia64
I end up with "Domain-Unnamed" after I save a PV domain and another
after I restore it, then do a shutdown.  Reverting this patch restores
correct behavior.  Thanks,

	Alex

On Tue, 2007-12-04 at 10:26 +0000, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser
> # Date 1196763935 0
> # Node ID d2bef6551c1263e457aef75ce403ba53652a803f
> # Parent  190c2592247d3258d6b2c60939d27928c70ac5ca
> xsm: Consolidate xsm processing within domain control hypercall.
> 
> Consolidate all the 15 xsm calls from within do_domctl a single
> routine that is only called in one place, xsm_domctl:
> 
> int xsm_domctl (struct xen_domctl *domctl);
> 
> The parameter to domctl is a pointer to the xen_domctl structure that
> contains a union of all sub operational parameters.
> 
> The benefits of this patch include:
> 
> (1) Easier to maintain because there is one place in the entire
> hypercall to check with the xsm, instead of 15 or more.
> 
> (2) New sub-operations don't also need to add a corresponding xsm
>     function.
> 
> (3) Removes 178 lines of code.
> 
> (4) Enhanced security because of 1-4.
> 

-- 
Alex Williamson                             HP Open Source & Linux Org.