From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linuxppc-dev@ozlabs.org, olof@lixom.net
Subject: Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code
Date: Wed, 05 Dec 2007 07:31:13 +1100 [thread overview]
Message-ID: <1196800273.13230.333.camel@pasglop> (raw)
In-Reply-To: <200712042036.00785.arnd@arndb.de>
On Tue, 2007-12-04 at 20:35 +0100, Arnd Bergmann wrote:
>
> 1. If another platform gets added that uses the same firmware feature,
> it
> will automatically do the right thing.
Yes but is it something that we want to happen ? That is, do we want
code somewhere in a platform/foo dir to run when using platform/bar
because they happen to share a feature ?
I don't think so ... such code should be located elsewhere, maybe in
sysdev, where it's clear that it's shared.
Thus, thing that is -really- platform specific and wants to stay in the
platform code should move to the new mechanism I believe.
As for PS3, will there ever be another platform using LV1 ? If that is
the case, we may want to create a shared directory with all the LV1
bits...
> 2. The call to firmware_has_feature() turns into a compile-time check
> in
> many cases, so if the kernel does not contain support for any firmware
> with the given feature, all the code referenced it can get optimized
> away by the compiler.
The machine init stuff will soon get rid of whatever test is in it too,
as soon as I get to do the ELF magic.
Ben.
next prev parent reply other threads:[~2007-12-04 20:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 6:10 [PATCH v2 1/2] [POWERPC] Add machine initcall macros Grant Likely
2007-12-02 6:10 ` [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code Grant Likely
2007-12-02 6:17 ` Grant Likely
2007-12-02 19:15 ` Olof Johansson
2007-12-04 12:23 ` Geert Uytterhoeven
2007-12-04 13:36 ` Grant Likely
2007-12-04 13:43 ` Geert Uytterhoeven
2007-12-04 20:59 ` Geoff Levand
2007-12-04 14:21 ` Grant Likely
2007-12-04 19:35 ` Arnd Bergmann
2007-12-04 20:31 ` Benjamin Herrenschmidt [this message]
2007-12-04 21:52 ` Arnd Bergmann
2007-12-04 22:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196800273.13230.333.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.