From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: xsm: Consolidate xsm processing within domain
	control hypercall.
Date: Tue, 04 Dec 2007 14:52:49 -0700
Message-ID: <1196805169.19310.59.camel@lappy>
References: <200712041026.lB4AQPM6004133@latara.uk.xensource.com>
	<1196798782.19310.36.camel@lappy> <1196801047.19310.38.camel@lappy>
	<20071204213640.GA23369@silverwood.ncultra.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20071204213640.GA23369@silverwood.ncultra.org>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: ncmike@us.ibm.com
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org


On Tue, 2007-12-04 at 16:36 -0500, Mike D. Day wrote:
> On 04/12/07 13:44 -0700, Alex Williamson wrote:
> >=20
> > On Tue, 2007-12-04 at 13:06 -0700, Alex Williamson wrote:
> > > Does this work right across a PV domain save/restore on x86?  On ia=
64
> > > I end up with "Domain-Unnamed" after I save a PV domain and another
> > > after I restore it, then do a shutdown.  Reverting this patch resto=
res
> > > correct behavior.  Thanks,
> >=20
> >    This also doesn't look like it builds with XSM_ENABLE=3Dy
> >  Alex -- Alex Williamson HP Open Source & Linux Org.
>=20
> It builds, if you like I'll send you a build log.

   Hmm, I'm not sure how.  Fails for me as shown below (x86_64).  Does
x86 have the save/restore issue I mentioned?  Thanks,

	Alex

cset 16519:62451388f630
$ make XSM_ENABLE=3Dy FLASK_ENABLE=3Dy xen
...
gcc -O2 -fomit-frame-pointer -m64 -DNDEBUG -fno-strict-aliasing
-std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value
-Wdeclaration-after-statement -DVMXASSIST -nostdinc -fno-builtin
-fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe
-I/tmp/test/xen/include -I/tmp/test/xen/include/asm-x86/mach-generic
-I/tmp/test/xen/include/asm-x86/mach-default -msoft-float
-fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks
-fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g
-D__XEN__ -DXSM_ENABLE -DFLASK_ENABLE -DXSM_MAGIC=3D0xf97cff8c
-DFLASK_DEVELOP -DFLASK_BOOTPARAM -DFLASK_AVC_STATS -c domctl.c -o
domctl.o
In file included from domctl.c:27:
/tmp/test/xen/include/xsm/xsm.h: In function =E2=80=98xsm_getdomaininfo=E2=
=80=99:
/tmp/test/xen/include/xsm/xsm.h:148: error: =E2=80=98struct xsm_operation=
s=E2=80=99 has
no member named =E2=80=98domain_getdomaininfo=E2=80=99
make[4]: *** [domctl.o] Error 1
make[4]: Leaving directory `/tmp/test/xen/common'
make[3]: *** [/tmp/test/xen/common/built_in.o] Error 2
make[3]: Leaving directory `/tmp/test/xen/arch/x86'
make[2]: *** [/tmp/test/xen/xen] Error 2
make[2]: Leaving directory `/tmp/test/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/tmp/test/xen'
make: *** [install-xen] Error 2

--=20
Alex Williamson                             HP Open Source & Linux Org.