From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86: Unify include/asm-x86/linkage_[32|64].h
Date: Tue, 04 Dec 2007 14:21:08 -0800 [thread overview]
Message-ID: <1196806868.10408.33.camel@brick> (raw)
In-Reply-To: <20071204213247.GA11216@elte.hu>
On Tue, 2007-12-04 at 22:32 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > I'm not sure if the definition of asmlinkage and prevent_tail_call can
> > be omitted as well and let the linux/linkage.h version get picked up
> > instead.
>
> no, we cannot remove them - asmlinkage is needed for the syscall entry
> (and other entry code) to work, the and the prevent_tail_call works
> around a compiler bug. (which might or might not be fixed in latest gcc
> - but we generally dont remove workarounds unless we are really sure
> it's fine.)
OK, but if this patch is acceptable, then there is no more places in the
tree that define the FASTCALL macro, other than the empty default in
include/linux/linkage.h. So I think a second step would be to start to
get rid of FASTCALL callers elsewhere in the tree...thoughts?
Cheers,
Harvey
next prev parent reply other threads:[~2007-12-04 22:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 20:53 [RFC PATCH] x86: Unify include/asm-x86/linkage_[32|64].h Harvey Harrison
2007-12-04 21:32 ` Ingo Molnar
2007-12-04 22:21 ` Harvey Harrison [this message]
2007-12-04 22:27 ` Ingo Molnar
2007-12-04 22:33 ` Harvey Harrison
2007-12-04 22:45 ` Adrian Bunk
2007-12-04 22:57 ` Harvey Harrison
2007-12-04 23:15 ` Adrian Bunk
2007-12-05 0:19 ` Jeff Dike
2007-12-05 9:31 ` Adrian Bunk
2007-12-05 10:18 ` Ingo Molnar
2007-12-05 12:17 ` Adrian Bunk
2007-12-05 0:17 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196806868.10408.33.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.