From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: linuxppc-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources
Date: Mon, 10 Dec 2007 17:19:55 +1100 [thread overview]
Message-ID: <1197267595.6563.58.camel@pasglop> (raw)
In-Reply-To: <20071210061559.2E3DDDDE02@ozlabs.org>
On Mon, 2007-12-10 at 17:15 +1100, Benjamin Herrenschmidt wrote:
> The current pci_assign_unassigned_resources() code doesn't work properly
> on 32 bits platforms with 64 bits resources. The main reason is the use
> of unsigned long in various places instead of resource_size_t.
>
> This fixes it, along with some tricks to avoid casting to 64 bits on
> platforms that don't need it in every printk around.
>
> This is a pre-requisite for making powerpc use the generic code instead of
> its own half-useful implementation.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> This version now uses casts as Greg asked for and adds proper setup
> of the prefetchable base & limit "upper" registers when using 64 bits
> resources.
Crap ! Ignore it. I forgot to quilt ref again... won't build.
Sending it again, with a separate patch fixing a warning in setup-res.c
that isn't directly related to the changes to setup-bus.c
Cheers,
Ben.
next prev parent reply other threads:[~2007-12-10 6:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 6:15 [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources Benjamin Herrenschmidt
2007-12-10 6:15 ` Benjamin Herrenschmidt
2007-12-10 6:19 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-05 6:40 Benjamin Herrenschmidt
2007-12-05 6:40 ` Benjamin Herrenschmidt
2007-12-06 3:22 ` Benjamin Herrenschmidt
2007-12-06 3:22 ` Benjamin Herrenschmidt
2007-12-06 6:39 ` Greg KH
2007-12-06 6:39 ` Greg KH
2007-12-06 7:58 ` Benjamin Herrenschmidt
2007-12-06 7:58 ` Benjamin Herrenschmidt
2007-12-06 8:13 ` Geert Uytterhoeven
2007-12-06 8:13 ` Geert Uytterhoeven
2007-12-06 8:16 ` Matthew Wilcox
2007-12-06 8:16 ` Matthew Wilcox
2007-12-06 13:24 ` Kumar Gala
2007-12-06 13:24 ` Kumar Gala
2007-12-06 13:35 ` Andreas Schwab
2007-12-06 13:35 ` Andreas Schwab
2007-12-06 22:37 ` Benjamin Herrenschmidt
2007-12-06 22:37 ` Benjamin Herrenschmidt
2007-12-07 1:00 ` Greg KH
2007-12-07 1:00 ` Greg KH
2007-12-09 7:16 ` Benjamin Herrenschmidt
2007-12-09 7:16 ` Benjamin Herrenschmidt
2007-12-04 6:08 Benjamin Herrenschmidt
2007-12-04 6:08 ` Benjamin Herrenschmidt
2007-12-04 12:39 ` Geert Uytterhoeven
2007-12-04 12:39 ` Geert Uytterhoeven
2007-12-04 19:57 ` Benjamin Herrenschmidt
2007-12-04 19:57 ` Benjamin Herrenschmidt
2007-12-05 2:37 ` Benjamin Herrenschmidt
2007-12-05 2:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197267595.6563.58.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.