From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Clemens Ladisch" Subject: Re: [alsa-cvslog] alsa-kernel: cmipci: disable "Modem" control on version 39 or newer chips Date: Mon, 10 Dec 2007 16:10:27 +0100 Message-ID: <1197299427.3147.1225765285@webmail.messagingengine.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com [66.111.4.27]) by alsa0.perex.cz (Postfix) with ESMTP id 6D8C71038D8 for ; Mon, 10 Dec 2007 16:10:28 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Thierry Vignaud Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Thierry Vignaud wrote: > Clemens Ladisch writes: > > description: > > cmipci: disable "Modem" control on version 39 or newer chips > > > > On version 39 or newer chips, we better remove the "Modem" control > > because this register bit now mutes the front channels of the > > multichannel stream. > > shouldn't that deserve a comment in the code? Not in my opinion. The "if (version < 39)" makes clear in which version the control is used, and both the old and new bits are documented in the respective data sheets. Regards, Clemens