Re: [PATCH] x86: Unify mmap_{32|64}.c

[Harvey Harrison <harvey.harrison@gmail.com>]

On Tue, 2007-12-11 at 15:08 +0100, Ingo Molnar wrote:
> * Jiri Kosina <jkosina@suse.cz> wrote:
> 
> > > hm, it fails to boot on Fedora 8:
> > >  Freeing unused kernel memory: 296k freed
> > >  Write protecting the kernel read-only data: 1500k
> > >  mount[623]: segfault at 0000000b ip 4d681ab6 sp bf9a1b94 error 6
> > >  modprobe[625]: segfault at 0000000b ip 4d681ab6 sp bffd9994 error 6
> > >  consoletype[629]: segfault at 0000000b ip 4d681ab6 sp bfb6ad14 error 6
> > >  awk[632]: segfault at 0000000b ip 4d681ab6 sp bffe68c4 error 6
> > >  fstab-decode[633]: segfault at 0000000b ip 4d681ab6 sp bff1c8c4 error 6
> > >  setsysfont[634]: segfault at 0000000b ip 4d681ab6 sp bfdd0f74 error 6
> > >  hwclock[637]: segfault at 0000000b ip 4d681ab6 sp bf963304 error 6
> > >  touch[642]: segfault at 0000000b ip 4d681ab6 sp bf98cb34 error 6
> > >  modprobe[651]: segfault at 0000000b ip 4d681ab6 sp bfbc0564 error 6
> > >  rhgb-client[654]: segfault at 0000000b ip 4d681ab6 sp bfe9c024 error 6
> > 
> > Ingo,
> > 
> > just for clarification -- this happens with Harvery's merged code 
> > (haven't looked at it yet), but not with the original code, do I 
> > understand it correctly?

Ingo,

Brown paper bag for me.

in mmap.c in mmap_is_ia32()

#ifdef X86_32

should of course be:

#ifdef CONFIG_X86_32

This would definitely explain the segfaults.  Do you want a replacement
patch or incremental?

Harvey