Re: [2.6 patch] drivers/pci/msi.c: move arch hooks to the top

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]


On Wed, 2007-12-12 at 00:00 +0100, Adrian Bunk wrote:
> On Wed, Dec 12, 2007 at 09:44:10AM +1100, Michael Ellerman wrote:
> > On Tue, 2007-12-11 at 23:19 +0100, Adrian Bunk wrote:
> > > This patch fixes the following problem present with older gcc versions:
> > > 
> > > <--  snip  -->
> > > 
> > > ...
> > >   CC      drivers/pci/msi.o
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:692: warning: weak declaration of `arch_msi_check_device' after first use results in unspecified behavior
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:704: warning: weak declaration of `arch_setup_msi_irqs' after first use results in unspecified behavior
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:724: warning: weak declaration of `arch_teardown_msi_irqs' after first use results in unspecified behavior
> > > ...
> > > 
> > > <--  snip  -->
> > 
> > They're declared in <linux/msi.h>, I don't see what it's problem is.
> 
> Older gcc versions don't like that they cannot see that they are weak 
> functions at the time when they are used.
> 
> I'm not sure whether the generated code does the right thing, but even 
> if it does rearranging the code doesn't do any harm here.

Sure.

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]