All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Remove 'e' from kprope structure members
Date: Wed, 12 Dec 2007 15:08:33 -0800	[thread overview]
Message-ID: <1197500913.21291.45.camel@brick> (raw)
In-Reply-To: <47606804.1010709@goop.org>

On Wed, 2007-12-12 at 15:00 -0800, Jeremy Fitzhardinge wrote:
> Harvey Harrison wrote:
> > Some kprobe structure members had a superfluous e in their
> > name.
> >
> > eflags -> flags
> > esp -> sp
> >   
> 
> eflags and esp are the actual machine register names (at least in
> 32-bit), and therefore more distinctive than just "flags". 
> 
> If this is in preparation for a unification then OK, but I disagree if
> not (and technically 64-bit should be using rsp/rflags).
> 
>     J

My plan was to move forward with unifying these files.  If this is still
acceptable I will add a comment block documenting this.  This doesn't
affect anywhere outside of kprobes.h kprobes_32/64.c so if it is clean
to unify them, I'll leave them as sp with comment.

Harvey


  reply	other threads:[~2007-12-12 23:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1197421087.8761.27.camel@brick>
     [not found] ` <47602776.10408@zytor.com>
2007-12-12 19:27   ` [PATCH] x86: Remove 'e' from kprope structure members Harvey Harrison
2007-12-12 23:00     ` Jeremy Fitzhardinge
2007-12-12 23:08       ` Harvey Harrison [this message]
2007-12-12 23:08       ` H. Peter Anvin
2007-12-12 23:20         ` Jeremy Fitzhardinge
2007-12-12 23:24           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197500913.21291.45.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.