From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Robert Hancock <hancockr@shaw.ca>,
linux-pci@atrey.karlin.mff.cuni.cz,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Possible issue with dangling PCI BARs
Date: Thu, 13 Dec 2007 20:29:23 +1100 [thread overview]
Message-ID: <1197538163.15741.124.camel@pasglop> (raw)
In-Reply-To: <20071213121435.C21124@jurassic.park.msu.ru>
On Thu, 2007-12-13 at 12:14 +0300, Ivan Kokshaysky wrote:
> On Thu, Dec 13, 2007 at 04:26:42PM +1100, Benjamin Herrenschmidt wrote:
> > I can try to whip up some code tomorrow I suppose, though I'm always
> > afraid some dodgy x86 setup will blow up...
>
> That scares me too, but something like pci_dangling_bar(dev, idx) with
> a default (for now) no-op implementation in asm-generic/pci.h should
> be safe...
Well, the code that detects collisions and "unsets" a resource is arch
in the first place, and so is pcibios_enable_device().
So I'm going to do a powerpc implementation & test it a bit with what I
have around, and then do an x86 since with my latest (pending for .25)
patches. powerpc PCI code is -very- similar to x86.
Cheers,
Ben.
next prev parent reply other threads:[~2007-12-13 9:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.YfTvVN5C3e6zwXPW5biWgeZ9XXc@ifi.uio.no>
[not found] ` <fa.EhUqlM3V3y3HCcQkLBLSEKTJxBs@ifi.uio.no>
[not found] ` <fa.4FjaYKIciOijtgO+0DDrMkrLjv0@ifi.uio.no>
2007-12-13 4:22 ` Possible issue with dangling PCI BARs Robert Hancock
2007-12-13 5:26 ` Benjamin Herrenschmidt
2007-12-13 9:14 ` Ivan Kokshaysky
2007-12-13 9:29 ` Benjamin Herrenschmidt [this message]
2007-12-13 9:04 ` Ivan Kokshaysky
2007-12-13 10:24 ` Alan Cox
2007-12-13 11:17 ` Benjamin Herrenschmidt
2007-12-13 11:20 ` Benjamin Herrenschmidt
2007-12-13 20:04 ` Jesse Barnes
2007-12-13 20:51 ` Benjamin Herrenschmidt
2007-12-13 21:12 ` Ivan Kokshaysky
2007-12-13 23:09 ` Benjamin Herrenschmidt
2007-12-13 21:02 ` Ivan Kokshaysky
2007-12-13 13:27 ` Alan Cox
2007-12-13 3:00 Benjamin Herrenschmidt
2007-12-13 3:04 ` Benjamin Herrenschmidt
2007-12-13 3:40 ` Benjamin Herrenschmidt
2007-12-14 11:52 ` Jon Masters
2007-12-14 22:11 ` Benjamin Herrenschmidt
2007-12-15 2:18 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197538163.15741.124.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hancockr@shaw.ca \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.