From: Steffen Prohaska <prohaska@zib.de>
To: git@vger.kernel.org
Cc: Steffen Prohaska <prohaska@zib.de>
Subject: [RFC 4/4] gitk: Use adddiffline to nicely format diff-diff
Date: Sat, 15 Dec 2007 17:51:45 +0100 [thread overview]
Message-ID: <11977375052395-git-send-email-prohaska@zib.de> (raw)
In-Reply-To: <11977375051617-git-send-email-prohaska@zib.de>
---
gitk-git/gitk | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 3c4ec03..31b2b5f 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -6059,8 +6059,9 @@ proc doseldiffdiff {oldid newid} {
set diff [exec git diff-diff $oldid $newid]
$ctext conf -state normal
- $ctext insert end "\n"
- $ctext insert end $diff
+ foreach line [split $diff "\n"] {
+ adddiffline $line [list $oldid $newid]
+ }
$ctext conf -state disabled
}
--
1.5.4.rc0.37.geff3a-dirty
next prev parent reply other threads:[~2007-12-15 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-15 16:51 [RFC 1/4] Add diff-diff, which compares the diffs of two commits Steffen Prohaska
2007-12-15 16:51 ` [RFC 2/4] gitk: Add diff-diff support Steffen Prohaska
2007-12-15 16:51 ` [RFC 3/4] gitk: Refactor getblobdiffline to split off adddiffline Steffen Prohaska
2007-12-15 16:51 ` Steffen Prohaska [this message]
2007-12-15 16:55 ` [RFC 1/4] Add diff-diff, which compares the diffs of two commits Johannes Schindelin
2007-12-15 17:04 ` Björn Steinbrink
2007-12-15 17:33 ` Steffen Prohaska
2007-12-15 19:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11977375052395-git-send-email-prohaska@zib.de \
--to=prohaska@zib.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.