All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Stoppa <igor.stoppa@nokia.com>
To: "ext Woodruff, Richard" <r-woodruff2@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: RE: [PATCH] Remove omap_sram_idle()
Date: Sun, 16 Dec 2007 17:11:41 +0200	[thread overview]
Message-ID: <1197817901.14417.11.camel@mort> (raw)
In-Reply-To: <3B6D69C3A9EBCA4BA5DA60D91302742902CC143D@dlee13.ent.ti.com>


On Sun, 2007-12-16 at 08:44 -0600, ext Woodruff, Richard wrote:
> > 	This patch removes omap_sram_idle().
> 
> Why?
> 
> > Signed-off-by: Vivek Kutal <vivek.kutal@celunite.com>
> 
> Execution in SRAM on some OMAPs is needed and in others it provides a more likely path to hitting deep sleep states.  There is sensitivity of running in SDRAM when trying to shut this down.
> 
> On 1509 there was not alternative as sleeping when the SDR was not in self-refresh was impossible.  On 1510 an automated self-refresh was added based on an internal signal.
> 
> I've not tried an OMAP1 in a while so I'm not sure what issues there might be today.  There are tree's which do hit big and deep sleep and I think they still use something close to this.

Yup. Nokia 770 is one of them.
Or was, at least, I have to admit that I haven't checked an OMAP1 kernel
for a long time. But it used to work.

Vivek: did you make any measurement on your patch? It would be good if
you could share your findings.

-- 
Cheers, Igor

Igor Stoppa <igor.stoppa@nokia.com>
(Nokia Multimedia - CP - OSSO / Helsinki, Finland)

  reply	other threads:[~2007-12-16 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16  7:57 [PATCH] Remove omap_sram_idle() Vivek Kutal
2007-12-16 14:44 ` Woodruff, Richard
2007-12-16 15:11   ` Igor Stoppa [this message]
2007-12-17  6:24   ` Vivek Kutal
2007-12-17 18:25     ` Tony Lindgren
2007-12-16 16:06 ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197817901.14417.11.camel@mort \
    --to=igor.stoppa@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=r-woodruff2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.