All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] Beautify about dialog
Date: Sun, 16 Dec 2007 23:24:07 +0000	[thread overview]
Message-ID: <1197847447.26210.268.camel@cookie.hadess.net> (raw)
In-Reply-To: <8a8adccc0712161443w7ba67743jc06515240cfdf83d@mail.gmail.com>

Hey Jaap,

On Sun, 2007-12-16 at 23:43 +0100, Jaap A. Haitsma wrote:
> Hi Marcel,
> 
> >
> > > Attached patch does the following
> > >
> > > * about dialog code is simpler
> >
> > you can't use gtk_dialog_run for the applet's about dialog. It will
> > block and thus block all PIN requests. The current code is this way for
> > a reason.
> 
> Didn't know that. I now use g_object_set which also reduces the amount
> of code considerably.

You can still use gtk_show_about_dialog(). It removes the close
callback, and makes sure that only one dialogue shows up, and removes a
lot of boiler-plate code (it doesn't use a separate main loop like
gtk_dialog_run does). The gtk_dialog_run avoidance in the callbacks is
still needed.

Cheers


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2007-12-16 23:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16 21:09 [Bluez-devel] [PATCH] Beautify about dialog Jaap A. Haitsma
2007-12-16 21:47 ` Marcel Holtmann
2007-12-16 22:43   ` Jaap A. Haitsma
2007-12-16 23:24     ` Bastien Nocera [this message]
2007-12-17  1:03       ` Marcel Holtmann
2007-12-17  7:15         ` Jaap A. Haitsma
2007-12-17  7:54           ` Jaap A. Haitsma
2007-12-17 10:43             ` Bastien Nocera
2007-12-17 19:04           ` Marcel Holtmann
2007-12-18 21:52             ` Jaap A. Haitsma
2007-12-18 23:22               ` Marcel Holtmann
2007-12-20 22:24                 ` Jaap A. Haitsma
2007-12-17  0:58     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197847447.26210.268.camel@cookie.hadess.net \
    --to=hadess@hadess.net \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.