All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons
Date: Mon, 17 Dec 2007 06:47:39 +0100	[thread overview]
Message-ID: <1197870459.8050.80.camel@aeonflux> (raw)
In-Reply-To: <5f84803c0712060959n6db58e78y4adfa1b4a212df71@mail.gmail.com>

Hi Chris,

> Attached is an updated patch with the changes that we talked about.

the patch looks good, but using bluetooth_application_instance is too
long for my taste. Use bluetooth_instance to make this shorter.

Also use org.bluez.properties etc. for the service names
and /org/bluez/properties etc. for the object path.

I also like to have multiple separate patches. One that add the generic
instance code and then additional patches that adds support for it to
every application. This makes it a lot easier for me to review and apply
it.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  parent reply	other threads:[~2007-12-17  5:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-03 15:33 [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons Chris Rivera
2007-12-03 16:25 ` Marcel Holtmann
2007-12-03 16:50   ` Chris Rivera
2007-12-03 16:59     ` Marcel Holtmann
2007-12-06 17:59       ` Chris Rivera
2007-12-17  3:08         ` Chris Rivera
2007-12-17  5:47         ` Marcel Holtmann [this message]
2007-12-17 15:54           ` Chris Rivera
2007-12-17 18:53             ` Marcel Holtmann
2007-12-17 19:29               ` Chris Rivera
2007-12-17 20:17                 ` Marcel Holtmann
2007-12-17 20:47                   ` Chris Rivera
2007-12-17 21:01                     ` Marcel Holtmann
2007-12-18 18:37                       ` Chris Rivera
2007-12-18 19:10                         ` Marcel Holtmann
2007-12-18 19:51                           ` Chris Rivera
2007-12-18 19:58                             ` Marcel Holtmann
2007-12-18 20:52                               ` Bastien Nocera
2007-12-18 21:00                                 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197870459.8050.80.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.