From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, Alan Cox <alan@redhat.com>,
Greg Kroah-Hartman <greg@kroah.com>,
jgarzik@pobox.com, Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
wingel@nano-system.com,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
james.smart@emulex.com, linux-driver@qlogic.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()
Date: Tue, 18 Dec 2007 11:26:26 +1100 [thread overview]
Message-ID: <1197937586.13400.22.camel@pasglop> (raw)
In-Reply-To: <20071218000740.446a6adf@the-village.bc.nu>
On Tue, 2007-12-18 at 00:07 +0000, Alan Cox wrote:
> On Tue, 18 Dec 2007 10:01:14 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > This patch converts users of pci_enable_device_bars() to the new
> > pci_enable_device_{io,mem} interface.
> >
> > The new API fits nicely, except maybe for the QLA case where a bit of
> > code re-organization might be a good idea but I prefer sticking to the
> > simple patch as I don't have hardware to test on.
> >
> > I'll also need some feedback on the cs5520 change
>
> 5520 in fact is always enabled as it is the host bridge.
> pci_enable_device_io will do just fine. The 5520 fun is if you disable it
> the system hangs.
Ok, thanks, that's not my idea of fun though :-)
Cheers,
Ben.
next prev parent reply other threads:[~2007-12-18 0:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 23:01 [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces Benjamin Herrenschmidt
2007-12-17 23:01 ` [RFC/PATCH 3/4] pci: Remove pci_enable_device_bars() Benjamin Herrenschmidt
2007-12-24 7:08 ` Grant Grundler
2007-12-25 21:16 ` Benjamin Herrenschmidt
2007-12-17 23:01 ` [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars() Benjamin Herrenschmidt
2007-12-18 0:07 ` Alan Cox
2007-12-18 0:26 ` Benjamin Herrenschmidt [this message]
2007-12-24 7:13 ` Grant Grundler
2007-12-17 23:01 ` [RFC/PATCH 4/4] [POWERPC] pci: Disable IO/Mem on a device when resources can't be allocated Benjamin Herrenschmidt
2007-12-18 9:56 ` Ivan Kokshaysky
2007-12-18 11:36 ` Benjamin Herrenschmidt
2007-12-24 7:23 ` Grant Grundler
2007-12-25 21:20 ` Benjamin Herrenschmidt
2007-12-25 21:26 ` Benjamin Herrenschmidt
2007-12-27 21:03 ` Grant Grundler
2007-12-17 23:49 ` [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces Johannes Weiner
2007-12-17 23:55 ` Benjamin Herrenschmidt
2007-12-18 0:02 ` Benjamin Herrenschmidt
2007-12-18 9:37 ` Ivan Kokshaysky
2007-12-18 9:43 ` Benjamin Herrenschmidt
2007-12-19 5:10 ` [RFC/PATCH]] x86: pci: Disable IO/Mem on a device when resources can't be allocated Benjamin Herrenschmidt
2007-12-19 13:43 ` Ivan Kokshaysky
2007-12-19 20:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197937586.13400.22.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=bzolnier@gmail.com \
--cc=greg@kroah.com \
--cc=ink@jurassic.park.msu.ru \
--cc=james.smart@emulex.com \
--cc=jgarzik@pobox.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=wingel@nano-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.