From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Date: Tue, 18 Dec 2007 02:33:58 +0000 Subject: Re: [kvm-ppc-devel] Current e500 kvm guest kernel booting log Message-Id: <1197945239.5026.12.camel@diesel> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Fri, 2007-12-14 at 14:15 +0800, Zhang Wei wrote: > > Hollis Blanchard wrote: > > > On Thu, 2007-12-13 at 18:14 +0800, Zhang Wei wrote: > > >>> From: Hollis Blanchard [mailto:hollisb@us.ibm.com] > > >>>>> We haven't touched the "hack" code recently, since we've been > > >>>>> refactoring the upstream tree. That's pretty much done > > >>>>> though, and right > > >>>>> now I'm just starting to integrate the old 440 support with the > > >>>>> new upstream code. That's not in a good state right now, but I > > >>>>> could clean it up and send it out if you're interested. > > >>>> > > >>>> Yes! I think hack codes are only for verifying the idea. Our > > >>>> target is for upstream code. I hope I could join you! > > >>> > > >>> Well, unfortunately at the moment I'm just fighting with > > >>> asm-offsets.h . :( Since I'm basically already on vacation, > > >>> I'm not sure > > >>> I'll be able to get anything ready until January. > > >>> > > >> > > >> Do you mind send out the asm-offsets.h? Maybe I can take it base on > > >> the hack code. > > > > > > Oh, the file is the same. The problem is how to have Kbuild > > > automatically generate it. > > > > IA64 have the same issues , do you have good idea to handle > > it ? Now, I > > let kvm makefile to call a extenal script to solve it. :) > > > > Do you mean if you change the struct kvm_vcpu of the kvm.h file, but the > asm-offsets.h file can not be re-generated by your current Makefile? > > If it is, you can modify Makefile as below: > - $(obj)/kvm-offsets.s: $(src)/kvm-offsets.c > + $(obj)/kvm-offsets.s: $(src)/kvm-offsets.c FORCE > > Or is there any other problems about asm-offsets.h in Makefile? Yes, there is a larger problem: forget the dependencies; how do we generate asm-offsets.h in the first place? The Makefile hackery that I've posted before is not a good solution, and I'm looking for that good solution. IA64 needs to generate its own asm-offsets too, and so does lguest. That's why I've been looking at the "mkasm-values" patches recently (google it)... -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel