From: Adam Jackson <ajax@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apm_event{,info}_t are userspace types.
Date: Wed, 19 Dec 2007 14:00:56 -0500 [thread overview]
Message-ID: <1198090856.30771.236.camel@localhost.localdomain> (raw)
In-Reply-To: <20071212024700.19560b60.akpm@linux-foundation.org>
On Wed, 2007-12-12 at 02:47 -0800, Andrew Morton wrote:
> On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:
> > These types define the size of data read from /dev/apm_bios. They
> > should not be hidden behind #ifdef __KERNEL__.
>
> Missing info: what are the consequences of this fix? What id broken when
> it it not applied?
The X server won't build. Neither will apmd, but it's harder for me to
get worked up about that.
> > ---
> > include/linux/apm_bios.h | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Please include Signed-off-by:, as per Documentation/SubmittingPatches,
> thanks.
Blah. Right, will remember git-format-patch -s next time. In any
event:
Signed-off-by: Adam Jackson <ajax@redhat.com>
- ajax
next prev parent reply other threads:[~2007-12-19 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 20:02 [PATCH] apm_event{,info}_t are userspace types Adam Jackson
2007-12-12 10:47 ` Andrew Morton
2007-12-13 21:03 ` Eamon Walsh
2007-12-19 19:00 ` Adam Jackson [this message]
2007-12-18 4:33 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198090856.30771.236.camel@localhost.localdomain \
--to=ajax@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.