From: Peter Zijlstra <peterz@infradead.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
Date: Sat, 29 Dec 2007 02:42:24 +0100 [thread overview]
Message-ID: <1198892544.6821.103.camel@twins> (raw)
In-Reply-To: <a8e1da0712281736p6dcc3f05vdb3b8ed9618e0147@mail.gmail.com>
On Sat, 2007-12-29 at 09:36 +0800, Dave Young wrote:
> On Dec 29, 2007 9:29 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> >
> > I'm pretty sure you didn't boot that kernel with lockdep enabled.
> Yes, I will try rebuild with lockdep and test.
I'll fail miserably :-)
>From your other mail:
> No, I checked the config , lockdep is indeed enabled. But I will try
> to test with the lock debug options enabled in a while.
You need to actually boot the kernel to get effective reports from
lockdep, it'll build just fine.
> > Also, most, if not all, of your patches miss a patch description.
>
> Does the description really needed for it? IMHO, the subject is enough
> to descript the patches.
Preferably, the subject might convey what you are doing, but the full
description should at least add to that by telling _why_ you are doing
that.
Also, I don't think your series is bisectable, ie. 1/12 changes
device::sem -> device::mutex, and 12/12 changes a user of it.
next prev parent reply other threads:[~2007-12-29 1:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 1:01 [PATCH 01/12] Use mutex instead of semaphore in driver core Dave Young
2007-12-29 1:29 ` Peter Zijlstra
2007-12-29 1:36 ` Dave Young
2007-12-29 1:40 ` Dave Young
2007-12-29 1:42 ` Peter Zijlstra [this message]
2007-12-29 1:52 ` Dave Young
2007-12-29 1:57 ` Peter Zijlstra
2007-12-29 2:03 ` Dave Young
2007-12-29 2:36 ` Dave Young
2007-12-29 4:42 ` Greg KH
2007-12-29 5:06 ` Dave Young
2007-12-29 7:07 ` Dave Young
2007-12-29 17:07 ` Greg KH
2008-01-02 0:54 ` Dave Young
2008-01-02 5:18 ` Greg KH
2008-01-02 5:25 ` David Miller
2008-01-02 7:00 ` Greg KH
2008-01-02 7:52 ` David Miller
2008-01-02 12:39 ` Jarek Poplawski
2008-01-02 13:12 ` Jarek Poplawski
2008-01-02 16:08 ` Alan Stern
2008-01-03 1:00 ` Dave Young
2008-01-02 5:37 ` Dave Young
2007-12-29 22:01 ` Alan Stern
2007-12-30 6:42 ` David Brownell
2007-12-30 12:13 ` Peter Zijlstra
2008-01-08 16:54 ` Jiri Kosina
2008-01-02 0:58 ` Dave Young
2008-01-02 16:06 ` Alan Stern
2008-01-05 9:30 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198892544.6821.103.camel@twins \
--to=peterz@infradead.org \
--cc=gregkh@suse.de \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.